Allow backup ID to be passed to restore endpoint.#5208
Merged
Conversation
manishrjain
approved these changes
Apr 15, 2020
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
systest/online-restore/online_restore_test.go, line 141 at r1 (raw file):
func TestInvalidBackupId(t *testing.T) { restoreRequest := `mutation restore() { restore(input: {location: "/data/alpha1/backup", backupId: "bad-backup-id"}) {
Add another test for good backup id.
martinmr
commented
Apr 15, 2020
Contributor
Author
martinmr
left a comment
martinmr
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
systest/online-restore/online_restore_test.go, line 141 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Add another test for good backup id.
Done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backup ID can now be passed to select a specific series of backups.
This change is
Docs Preview: