Skip to content

Fix panic in Task FrameWork, fixes #5034#5081

Merged
mangalaman93 merged 1 commit intomasterfrom
aman/5034
Apr 3, 2020
Merged

Fix panic in Task FrameWork, fixes #5034#5081
mangalaman93 merged 1 commit intomasterfrom
aman/5034

Conversation

@mangalaman93
Copy link
Copy Markdown
Contributor

@mangalaman93 mangalaman93 commented Apr 2, 2020

This change is Reviewable

@mangalaman93 mangalaman93 requested review from a team and parasssh April 2, 2020 09:25
Copy link
Copy Markdown
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @parasssh)

Copy link
Copy Markdown
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mangalaman93 mangalaman93 merged commit 8482527 into master Apr 3, 2020
@mangalaman93 mangalaman93 deleted the aman/5034 branch April 3, 2020 16:26
parasssh pushed a commit that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants