Verify host when default and custom credentials are used.#4858
Merged
Verify host when default and custom credentials are used.#4858
Conversation
Currently, the host is only checked when the default credentials are used. This means using custom credentials will not work if there's no host in the destination URI as the logic that handles this case is not executed. This PR changes the logic so that these checks are always executed, regardless of the status of the credentials.
manishrjain
approved these changes
Mar 17, 2020
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
martinmr
added a commit
that referenced
this pull request
Mar 17, 2020
Currently, the host is only checked when the default credentials are used. This means using custom credentials will not work if there's no host in the destination URI as the logic that handles this case is not executed. This PR changes the logic so that these checks are always executed, regardless of the status of the credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the host is only checked when the default credentials are
used. This means using custom credentials will not work if there's no
host in the destination URI as the logic that handles this case is not
executed.
This PR changes the logic so that these checks are always executed,
regardless of the status of the credentials.
Fixes #4855
This change is