x: increment loop variable#4036
Merged
manishrjain merged 1 commit intodgraph-io:masterfrom Sep 24, 2019
shawnps:patch-1
Merged
Conversation
![hackerone-code[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@shawnps you can click here to see the review status or cancel the code review job.
|
|
mangalaman93
approved these changes
Sep 21, 2019
Contributor
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
poonai
approved these changes
Sep 23, 2019
Contributor
poonai
left a comment
poonai
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution <3
manishrjain
approved these changes
Sep 24, 2019
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may be mistaken but it seems that
ishould be getting incremented in this loop rather thanretries.This change is