Skip to content

Fix the zero client in live loader to avoid using TLS in 1.0.x#3936

Merged
gitlw merged 2 commits into
release/v1.0from
gitlw/fix_live_tls
Sep 10, 2019
Merged

Fix the zero client in live loader to avoid using TLS in 1.0.x#3936
gitlw merged 2 commits into
release/v1.0from
gitlw/fix_live_tls

Conversation

@gitlw
Copy link
Copy Markdown

@gitlw gitlw commented Sep 6, 2019 •
edited by manishrjain
Loading

since zero does not support TLS at this moment.

PS. this is not a issue in the master branch as there have been quite some changes around the TLS code.

This change is Reviewable

hackerone-code[bot]
hackerone-code Bot reviewed Sep 6, 2019
View reviewed changes
Copy link
Copy Markdown

@hackerone-code hackerone-code Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@gitlw you can click here to see the review status or cancel the code review job.

@martinmr
Copy link
Copy Markdown
Contributor

martinmr commented Sep 6, 2019 •
edited
Loading

Is this related to #3919?

@danielmai
Copy link
Copy Markdown
Contributor

danielmai commented Sep 6, 2019

@gitlw please merge with latest release/v1.0 branch. Looks like this change was done on top of an older version, so the CI tests failed.

martinmr
martinmr reviewed Sep 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: other than the CI issues. I would add how you tested this somewhere in the description. Not approving rn until the CI passes.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gitlw
Copy link
Copy Markdown
Author

gitlw commented Sep 6, 2019

@martinmr Yes, this fixes #3919

hackerone-code[bot]
hackerone-code Bot reviewed Sep 7, 2019
View reviewed changes
Copy link
Copy Markdown

@hackerone-code hackerone-code Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change conforms to description, and seems like it fixes the issue referenced. Wondering if there's any additional test cases required?

Reviewed with ❤️ by PullRequest

@gitlw gitlw merged commit d9bd76d into release/v1.0 Sep 10, 2019
@gitlw gitlw mentioned this pull request Sep 10, 2019
Closed
@danielmai danielmai deleted the gitlw/fix_live_tls branch July 31, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@martinmr martinmr martinmr left review comments

@hackerone-code hackerone-code[bot] hackerone-code[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gitlw @martinmr @danielmai