If HttpLogin function response contains error messages, return it directly#3275
Merged
manishrjain merged 1 commit intodgraph-io:masterfrom Apr 12, 2019
leechor:master
Merged
If HttpLogin function response contains error messages, return it directly#3275manishrjain merged 1 commit intodgraph-io:masterfrom leechor:master
manishrjain merged 1 commit intodgraph-io:masterfrom
leechor:master
Conversation
|
|
manishrjain
approved these changes
Apr 12, 2019
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If HttpLogin function response contains error messages，should print the error message from the alpha server , but now it print a unmarshall error. Not friendly enough.
This change is