Merged
Conversation
added 8 commits
April 9, 2019 11:11
…raph into javier/remove_dgraph_option
srfrog
approved these changes
Apr 9, 2019
Contributor
srfrog
left a comment
srfrog
left a comment
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
srfrog
approved these changes
Apr 9, 2019
Contributor
srfrog
left a comment
srfrog
left a comment
There was a problem hiding this comment.
Reviewable status:
golangcibot
reviewed
Apr 10, 2019
|
|
||
| var ( | ||
| addr = flag.String("addr", "localhost:9080", "dgraph address") | ||
| alpha = flag.String("alpha", "localhost:9080", "dgraph alpha address") |
|
|
||
| var ( | ||
| addr = flag.String("addr", "localhost:9080", "Dgraph alpha address") | ||
| alpha = flag.String("alpha", "localhost:9080", "Dgraph alpha address") |
manishrjain
approved these changes
Apr 11, 2019
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, 6 of 6 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)
danielmai
added a commit
that referenced
this pull request
Apr 11, 2019
The flag name changed in #3273.
danielmai
added a commit
that referenced
this pull request
Apr 12, 2019
The flag name changed in #3273.
danielmai
added a commit
that referenced
this pull request
Apr 12, 2019
The flag name changed in #3273.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
* Rename --dgraph option to --alpha. * Rename --addr option to --alpha. * Update tests to use renamed options.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
The flag name changed in dgraph-io#3273.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
The flag name changed in dgraph-io#3273.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a command line option
--dgraphthat's the same as the program namedgraphlooks ugly. Rename it to--alpha. For consistency, do it across all subcommands that use it (live, increment, and acl).Change summary:
--dgraphand--addrto--alphaand short option-dto-a.--auth_tokenshort option from-ato-t.This change is