Conversation
…k import rather than just the preds actually contained in that DB.
martinmr
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)
dgraph/cmd/bulk/loader.go, line 246 at r2 (raw file):
m
rename this variable to something a bit more descriptive. m implies a map but we are using this more as a set.
Ideas: usedPreds, fullPreds, seenPreds or something like that.
dgraph/cmd/bulk/run.go, line 136 at r2 (raw file):
os.Exit(1) } else if _, err := os.Stat(opt.DataFiles); err != nil && os.IsNotExist(err) { fmt.Fprintf(os.Stderr, "Data path(%v) does not exist .\n", opt.DataFiles)
Remove the blank space between exist and the period.
manishrjain
left a comment
There was a problem hiding this comment.
Merge after addressing @martinmr 's comments.
Reviewed 2 of 4 files at r2, 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)
codexnull
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @martinmr)
dgraph/cmd/bulk/loader.go, line 246 at r2 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
mrename this variable to something a bit more descriptive. m implies a map but we are using this more as a set.
Ideas: usedPreds, fullPreds, seenPreds or something like that.
I used m because it matches ld.schema.m below.
dgraph/cmd/bulk/run.go, line 136 at r2 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
Remove the blank space between exist and the period.
Done.
Change summary: * Each shard's schema contains only the predicates found in that shard rather than all preds. * Test case for above fix. * More user-friendly "file not found" messages rather than stack traces when bulk schema or data paths incorrect.
Change summary: * Each shard's schema contains only the predicates found in that shard rather than all preds. * Test case for above fix. * More user-friendly "file not found" messages rather than stack traces when bulk schema or data paths incorrect.
Change summary:
Each shard's schema contains only the predicates found in that shard rather than all preds.
Test case for above fix.
More user-friendly "file not found" messages rather than stack traces when bulk schema or data paths invalid.
This change is