Fix race condition in numShutDownSig in alpha

Author: animesh2049

dgraph/cmd/alpha/run.go

@@ -527,14 +527,14 @@ func run() {
 	sdCh := make(chan os.Signal, 3)
 	shutdownCh = make(chan struct{})
 
-	var numShutDownSig int
 	defer func() {
 		signal.Stop(sdCh)
 		close(sdCh)
 	}()
 	// sigint : Ctrl-C, sigterm : kill command.
 	signal.Notify(sdCh, os.Interrupt, syscall.SIGINT, syscall.SIGTERM)
 	go func() {
+		var numShutDownSig int
 		for {
 			select {
 			case _, ok := <-sdCh:
@@ -555,7 +555,6 @@ func run() {
 			}
 		}
 	}()
-	_ = numShutDownSig
 
 	// Setup external communication.
 	aclCloser := y.NewCloser(1)

worker/groups.go

@@ -289,8 +289,6 @@ func (g *groupi) applyState(state *pb.MembershipState) {
 }
 
 func (g *groupi) ServesGroup(gid uint32) bool {
-	// No need to acquire the lock on g because gid is always
-	// accessed atomically via groupId() function
 	return g.groupId() == gid
 }