Fix stream testing for Go v1.11

* Test stream server HandleFunc's stream an expected
message and then return an HTTP error response code
to break stream retrying, so received messages can be
checked
* Tests erroneously used 130 as the HTTP error response
code (130 is the Twitter code). Starting in Go v1.11,
such invalid HTTP response codes cause the connection to
the test stream server to hang, causing tests to hang.
* Fix the error code to be 500, some valid HTTP status
code that isn't handled specially (e.g. no backoff)

Author: dghubble

twitter/streams_test.go

@@ -106,7 +106,7 @@ func TestStream_Filter(t *testing.T) {
 			)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -146,7 +146,7 @@ func TestStream_Sample(t *testing.T) {
 			)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -183,7 +183,7 @@ func TestStream_User(t *testing.T) {
 			fmt.Fprintf(w, `{"friends": [666024290140217347, 666024290140217349, 666024290140217342]}`+"\r\n"+"\r\n")
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -223,7 +223,7 @@ func TestStream_User_TooManyFriends(t *testing.T) {
 			fmt.Fprintf(w, `{"friends": %s}`+"\r\n"+"\r\n", friendsList)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -264,7 +264,7 @@ func TestStream_Site(t *testing.T) {
 			)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -304,7 +304,7 @@ func TestStream_PublicFirehose(t *testing.T) {
 			)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -337,7 +337,7 @@ func TestStreamRetry_ExponentialBackoff(t *testing.T) {
 			http.Error(w, "Service Unavailable", 503)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})
@@ -371,7 +371,7 @@ func TestStreamRetry_AggressiveBackoff(t *testing.T) {
 			http.Error(w, "Too Many Requests", 429)
 		default:
 			// Only allow first request
-			http.Error(w, "Stream API not available!", 130)
+			http.Error(w, "Stream API not available!", 500)
 		}
 		reqCount++
 	})