Skip to content

Commit f4bb627

Browse files
authored
fix: tech debt removed from reconciler (#1339)
1 parent 4c8a418 commit f4bb627

File tree

4 files changed

+25
-14
lines changed

4 files changed

+25
-14
lines changed

pylib/__fix_import_paths.py

Lines changed: 0 additions & 11 deletions
This file was deleted.

release-controller/README.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ Make sure also that few minutes have passed and that public dashboard still does
162162
Please see the parent folder's `README.md` for virtual environment setup.
163163
Follow the whole *Contributing* section to the letter.
164164

165-
### Running the reconciler in dry-run mode:
165+
### Running the reconciler in dry-run mode
166166

167167
```sh
168168
bazel run //release-controller:release-controller -- --dry-run --verbose
@@ -201,6 +201,22 @@ canister. It is useful (in conjunction with an empty reconciler state folder)
201201
to make the reconciler do all the work of submitting proposals again. It should
202202
not be used without `--dry-run`, to avoid submitting proposals twice.
203203

204+
### Running the reconciler in the container it ships
205+
206+
You can load the reconciler into your local podman or docker system:
207+
208+
```sh
209+
bazel run //release-controller:oci_image_load
210+
```
211+
212+
This will spit out a SHA256 sum, which is the name of the container image just
213+
built and imported into your containerization system. Run it as follows:
214+
215+
```sh
216+
SHASUM=...
217+
podman run -it --entrypoint=/release-controller/release-controller $SHASUM
218+
```
219+
204220
### Tests
205221

206222
#### Unit tests

release-controller/reconciler.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import urllib.parse
1111

1212
sys.path.append(os.path.join(os.path.dirname(__file__)))
13-
import __fix_import_paths # isort:skip # noqa: F401 # pylint: disable=W0611
1413
import dre_cli
1514
import dryrun
1615
import release_index

tools/python/py_oci_image.bzl

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@aspect_bazel_lib//lib:tar.bzl", "mtree_spec", "tar")
2-
load("@rules_oci//oci:defs.bzl", "oci_image", "oci_push")
2+
load("@rules_oci//oci:defs.bzl", "oci_image", "oci_push", "oci_load")
33

44
# match *only* external repositories that have the string "python"
55
# e.g. this will match
@@ -76,6 +76,13 @@ def py_oci_image(name, binary, tars = [], **kwargs):
7676
**kwargs
7777
)
7878

79+
oci_load(
80+
name = "{}_load_locally".format(name),
81+
image = name,
82+
repo_tags = [],
83+
tags = ["manual"],
84+
)
85+
7986
binary_label = native.package_relative_label(binary)
8087
oci_push(
8188
name = "{}_push".format(name),

0 commit comments

Comments
 (0)