feat: query cancellation #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsTalwar
reviewed
Jan 20, 2024
meerkat-dbm/src/dbm/dbm.ts
Outdated
| connectionId?: string, | ||
| reject?: (reason?: any) => void | ||
| ): void { | ||
| signal?.addEventListener('abort', async (reason: Event) => { |
There was a problem hiding this comment.
Should we remove the event listener when the signal is completed ?
meerkat-dbm/src/dbm/dbm.ts
Outdated
| tableNames: string[], | ||
| options?: QueryOptions | ||
| ) { | ||
| private _abortSignal( |
There was a problem hiding this comment.
Can we rename this to signalHandler or signalListener
meerkat-dbm/src/dbm/dbm.ts
Outdated
Comment on lines
353
to
358
| /** | ||
| * Empty the queue | ||
| */ | ||
| public async emptyQueue() { | ||
| this.queriesQueue = []; | ||
| } |
There was a problem hiding this comment.
What is the use-case for this ?
meerkat-dbm/src/dbm/dbm.ts
Outdated
| public async queryWithTableNames({ | ||
| query, | ||
| tableNames, | ||
| connectionId, |
There was a problem hiding this comment.
let's not ask the consumer to pass this, auto-assign this id within this function
itsTalwar
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to empty queue
no-work-item