feat: add support for json register #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsTalwar
reviewed
Jan 1, 2024
| const startConversionTime = Date.now(); | ||
|
|
||
| // Register the JSON content as a json file in the DuckDB. | ||
| await db.registerFileText(`${tableName}.json`, JSON.stringify(json)); |
There was a problem hiding this comment.
Can we remove this plain text file from db after parquet is created
|
|
||
| const connection = await db.connect(); | ||
|
|
||
| const startConversionTime = Date.now(); |
There was a problem hiding this comment.
Instead of Date.now() can we use performance ?
itsTalwar
reviewed
Jan 1, 2024
| metadata: { ...metadata, json }, | ||
| }); | ||
|
|
||
| await db.registerEmptyFileBuffer(`${tableName}.json`); |
There was a problem hiding this comment.
a small nit, you are create ${tableName}.json and ${tableName}.parquet a lot of time in this function, can we create a variable on top of the function ?
itsTalwar
reviewed
Jan 1, 2024
| await page.waitForSelector('#loader', { timeout: 5000 }); | ||
|
|
||
| // Wait for the loader to disappear | ||
| await page.waitForTimeout(1750); |
There was a problem hiding this comment.
We shouldn't hardcode the values like this, based on machine it will change
Let's just check if the queries are running or not
vpbs2
force-pushed
the
feat/reigster-json
branch
from
d533339 to
0c12c75
Compare
itsTalwar
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add json register support
work-item: https://app.devrev.ai/devrev/works/ISS-72382