Skip to content

Commit 6283507

Browse files
committed
Fix typo "ociRegistryImage" instead of registryVolumeSize and secretName
Signed-off-by: Philippe Martin <[email protected]>
1 parent b82ab9d commit 6283507

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

DEVFILE_REGISTRY.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ The Devfile stacks are stored in OCI images served by the OCI registry container
140140

141141
You can ask the operator to create a Persistent Volume and to mount it into the `oci-registry` container's filesystem, so the OCI images are stored into this persistent volume, by setting the field `spec.storage.enabled` to `true`.
142142

143-
By default, the requested size for the Persistent Volume will be `1Gi`. You can ask to set a specific size with the field `spec.storage.ociRegistryImage`
143+
By default, the requested size for the Persistent Volume will be `1Gi`. You can ask to set a specific size with the field `spec.storage.registryVolumeSize`
144144

145145
```bash
146146
$ cat <<EOF | oc apply -f -
@@ -155,7 +155,7 @@ spec:
155155
registryName: test
156156
storage:
157157
enabled: true
158-
ociRegistryImage: 2Gi
158+
registryVolumeSize: 2Gi
159159
EOF
160160
```
161161

@@ -185,7 +185,7 @@ EOF
185185
```
186186

187187
You can ask the operator to configure the TLS with a specific certificate, by specifying a secret
188-
containing the certificate and the associated private key using the field `spec.tls.ociRegistryImage`:
188+
containing the certificate and the associated private key using the field `spec.tls.secretName`:
189189

190190
```bash
191191
$ kubectl create secret tls my-tls-secret --key=certs/ingress-tls.key --cert=certs/ingress-tls.crt
@@ -202,7 +202,7 @@ spec:
202202
registryName: test
203203
tls:
204204
enabled: true
205-
ociRegistryImage: my-tls-secret
205+
secretName: my-tls-secret
206206
EOF
207207
```
208208

api/v1alpha1/devfileregistry_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ type DevfileRegistrySpecStorage struct {
8181
// Configures the size of the devfile registry's persistent volume, if enabled.
8282
// Defaults to 1Gi.
8383
// +optional
84-
RegistryVolumeSize string `json:"ociRegistryImage,omitempty"`
84+
RegistryVolumeSize string `json:"registryVolumeSize,omitempty"`
8585
}
8686

8787
// DevfileRegistrySpecTLS defines the desired state for TLS in the DevfileRegistry
@@ -93,7 +93,7 @@ type DevfileRegistrySpecTLS struct {
9393

9494
// Name of an optional, pre-existing TLS secret to use for TLS termination on ingress/route resources.
9595
// +optional
96-
SecretName string `json:"ociRegistryImage,omitempty"`
96+
SecretName string `json:"secretName,omitempty"`
9797
}
9898

9999
// DevfileRegistrySpecK8sOnly defines the desired state of the kubernetes-only fields of the DevfileRegistry

bundle/manifests/registry.devfile.io_devfileregistries.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ spec:
108108
description: Instructs the operator to deploy the DevfileRegistry
109109
with persistent storage Disabled by default.
110110
type: boolean
111-
ociRegistryImage:
111+
registryVolumeSize:
112112
description: Configures the size of the devfile registry's persistent
113113
volume, if enabled. Defaults to 1Gi.
114114
type: string
@@ -142,7 +142,7 @@ spec:
142142
with TLS enabled. Enabled by default. Disabling is only recommended
143143
for development or test.
144144
type: boolean
145-
ociRegistryImage:
145+
secretName:
146146
description: Name of an optional, pre-existing TLS secret to use
147147
for TLS termination on ingress/route resources.
148148
type: string

config/crd/bases/registry.devfile.io_devfileregistries.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ spec:
109109
description: Instructs the operator to deploy the DevfileRegistry
110110
with persistent storage Disabled by default.
111111
type: boolean
112-
ociRegistryImage:
112+
registryVolumeSize:
113113
description: Configures the size of the devfile registry's persistent
114114
volume, if enabled. Defaults to 1Gi.
115115
type: string
@@ -143,7 +143,7 @@ spec:
143143
with TLS enabled. Enabled by default. Disabling is only recommended
144144
for development or test.
145145
type: boolean
146-
ociRegistryImage:
146+
secretName:
147147
description: Name of an optional, pre-existing TLS secret to use
148148
for TLS termination on ingress/route resources.
149149
type: string

0 commit comments

Comments
 (0)