Update workspace status message to include stopped and deleted

Update status message to show "Stopping"/"Stopped" when a workspace is
stopped, and "Cleaning up resources for deletion" when we're waiting on
a finalizer to be cleared.

Signed-off-by: Angel Misevski <[email protected]>

Author: amisevsk

controllers/workspace/finalize.go

@@ -63,6 +63,12 @@ func (r *DevWorkspaceReconciler) finalize(ctx context.Context, log logr.Logger,
 	if !hasFinalizer(workspace) {
 		return reconcile.Result{}, nil
 	}
+	workspace.Status.Message = "Cleaning up resources for deletion"
+	err := r.Client.Status().Update(ctx, workspace)
+	if err != nil && !k8sErrors.IsConflict(err) {
+		return reconcile.Result{}, err
+	}
+
 	// Need to make sure Deployment is cleaned up before starting job to avoid mounting issues for RWO PVCs
 	wait, err := provision.DeleteWorkspaceDeployment(ctx, workspace, r.Client)
 	if err != nil {

controllers/workspace/status.go

@@ -151,10 +151,13 @@ func getInfoMessage(workspace *devworkspace.DevWorkspace, conditions map[devwork
 	if msg, ok := conditions[devworkspace.WorkspaceFailedStart]; ok {
 		return msg
 	}
-	// Use ideUrl when workspace is running
-	if workspace.Status.Phase == devworkspace.WorkspaceStatusRunning {
+	switch workspace.Status.Phase {
+	case devworkspace.WorkspaceStatusRunning:
 		return workspace.Status.IdeUrl
+	case devworkspace.WorkspaceStatusStopped, devworkspace.WorkspaceStatusStopping:
+		return string(workspace.Status.Phase)
 	}
+
 	// Check for progress
 	if _, ok := conditions[devworkspace.WorkspaceReady]; ok {
 		return "Waiting on editor to start"