Skip to content

Commit b3ccdad

Browse files
committed
Mention limitations of per-workspace DWOC
1 parent 3accd18 commit b3ccdad

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

controllers/workspace/devworkspace_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ func (r *DevWorkspaceReconciler) dwPVCHandler(obj client.Object) []reconcile.Req
701701
}
702702
}
703703

704-
// TODO: Address this usage of global config?
704+
// TODO: Address this usage of global config. It'd be better to check if the PVC had a DWO-specific annotation that we can use to filter for
705705
// Otherwise, check if common PVC is deleted to make sure all DevWorkspaces see it happen
706706
if obj.GetName() != config.Workspace.PVCName || obj.GetDeletionTimestamp() == nil {
707707
// We're looking for a deleted common PVC

controllers/workspace/http.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ func setupHttpClients() {
3434
InsecureSkipVerify: true,
3535
}
3636

37+
// Note: per-workspace routing settings are ignored for the HTTP Clients
3738
if config.Routing != nil && config.Routing.ProxyConfig != nil {
3839
proxyConf := httpproxy.Config{
3940
HTTPProxy: config.Routing.ProxyConfig.HttpProxy,

0 commit comments

Comments
 (0)