File tree Expand file tree Collapse file tree 2 files changed +2
-1
lines changed Expand file tree Collapse file tree 2 files changed +2
-1
lines changed Original file line number Diff line number Diff line change @@ -701,7 +701,7 @@ func (r *DevWorkspaceReconciler) dwPVCHandler(obj client.Object) []reconcile.Req
701
701
}
702
702
}
703
703
704
- // TODO: Address this usage of global config?
704
+ // TODO: Address this usage of global config. It'd be better to check if the PVC had a DWO-specific annotation that we can use to filter for
705
705
// Otherwise, check if common PVC is deleted to make sure all DevWorkspaces see it happen
706
706
if obj .GetName () != config .Workspace .PVCName || obj .GetDeletionTimestamp () == nil {
707
707
// We're looking for a deleted common PVC
Original file line number Diff line number Diff line change @@ -34,6 +34,7 @@ func setupHttpClients() {
34
34
InsecureSkipVerify : true ,
35
35
}
36
36
37
+ // Note: per-workspace routing settings are ignored for the HTTP Clients
37
38
if config .Routing != nil && config .Routing .ProxyConfig != nil {
38
39
proxyConf := httpproxy.Config {
39
40
HTTPProxy : config .Routing .ProxyConfig .HttpProxy ,
You can’t perform that action at this time.
0 commit comments