-
Notifications
You must be signed in to change notification settings - Fork 77
feat(sapi): expand SapiBuilder
#471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af18bff
to
a17731e
Compare
Pull Request Test Coverage Report for Build 16006197694Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ad760b9
to
8644d1b
Compare
8644d1b
to
2533285
Compare
@Xenira This is the main SAPI-related change I need to be able to drop my fork. How does this look? Anything more you'd want from it? |
@Qard Thank you. Was on vacation the past few days and need to catch up as a lot happened while I was away. Will have a look as soon as possible. |
No worries. I hope it was a nice vacation! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Thank you! Only have the nitpickiest of nitpicky comments.
Co-authored-by: Xenira <[email protected]>
I've expanded the SapiBuilder to cover most of the API surface area. This also includes tests to verify the struct fields are set properly.
Do we want some functionality tests too? That'll be a bit more work as it's a bit complicated to set up a fully-functional environment properly.
I also adjusted some more tests that needed the
Embed::run(...)
wrapper to be ZTS-safe. I can pull those out to a separate PR though, if you prefer.