Skip to content

Commit a0d07b9

Browse files
authored
Clean up scheduler startup logging (#657)
* clean up scheduler startup logging * update cli tests for new logging information
1 parent 56ee9a5 commit a0d07b9

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

distributed/bokeh/application.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
'memory-usage.py', 'task-stream.py', 'task-progress.py',
2424
'resource-profiles.py', 'worker-table.py', 'processing-stacks.py']]
2525

26-
logger = logging.getLogger(__file__)
26+
logger = logging.getLogger(__name__)
2727

2828
dask_dir = os.path.join(os.path.expanduser('~'), '.dask')
2929
if not os.path.exists(dask_dir):
@@ -92,7 +92,7 @@ def cleanup_process():
9292
atexit.register(cleanup_process)
9393

9494
if not quiet:
95-
logger.info(" Bokeh UI at: http://%s:%d/status/"
95+
logger.info("Web UI: http://%s:%d/status/"
9696
% (ip, bokeh_port))
9797

9898
def close(self, join=True, timeout=None):

distributed/cli/dask_scheduler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ def del_pid_file():
6464
port = int(port)
6565
ip = socket.gethostbyname(host)
6666
loop = IOLoop.current()
67+
logger.info('-' * 47)
6768
scheduler = Scheduler(ip=ip, loop=loop,
6869
services={('http', http_port): HTTPScheduler})
6970
scheduler.start(port)
@@ -81,6 +82,8 @@ def del_pid_file():
8182
except Exception as e:
8283
logger.warn("Could not start Bokeh web UI", exc_info=True)
8384

85+
86+
logger.info('-' * 47)
8487
try:
8588
loop.start()
8689
loop.close()

distributed/cli/tests/test_dask_scheduler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_bokeh(loop):
5555

5656
while True:
5757
line = proc.stderr.readline()
58-
if b'Bokeh UI' in line:
58+
if b'Web UI' in line:
5959
break
6060

6161
names = ['localhost', '127.0.0.1', get_ip()]
@@ -89,7 +89,7 @@ def test_bokeh_non_standard_ports(loop):
8989

9090
while True:
9191
line = proc.stderr.readline()
92-
if b'Bokeh UI' in line:
92+
if b'Web UI' in line:
9393
break
9494

9595
start = time()
@@ -119,7 +119,7 @@ def test_bokeh_whitelist(loop):
119119

120120
while True:
121121
line = proc.stderr.readline()
122-
if b'Bokeh UI' in line:
122+
if b'Web UI' in line:
123123
break
124124

125125
start = time()
@@ -162,7 +162,7 @@ def check_pidfile(proc, pidfile):
162162
assert pid
163163
else:
164164
assert proc.pid == pid
165-
165+
166166
with tmpfile() as s:
167167
with popen(['dask-scheduler', '--pid-file', s]) as sched:
168168
check_pidfile(sched, s)

distributed/scheduler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,9 +395,9 @@ def start(self, port=8786, start_queues=True):
395395
self.listen(port)
396396

397397
self.status = 'running'
398-
logger.info("Scheduler at: %20s:%s", self.ip, self.port)
398+
logger.info(" Scheduler at: %20s:%s", self.ip, self.port)
399399
for k, v in self.services.items():
400-
logger.info("%9s at: %20s:%s", k, self.ip, v.port)
400+
logger.info("%11s at: %20s:%s", k, self.ip, v.port)
401401

402402
return self.finished()
403403

0 commit comments

Comments
 (0)