From 8eabe8d73b27ae97ec371f9e55e5195e34565590 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Thu, 17 Feb 2022 09:59:42 -0800 Subject: [PATCH 1/2] Change panel name to Dart Debugger --- dwds/debug_extension/web/devtools.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/debug_extension/web/devtools.js b/dwds/debug_extension/web/devtools.js index 9b5478613..44a3ff821 100644 --- a/dwds/debug_extension/web/devtools.js +++ b/dwds/debug_extension/web/devtools.js @@ -23,7 +23,7 @@ if (isDartApp) { created = true chrome.devtools.panels.create( - 'Dart', '', 'panel.html' + 'Dart Debugger', '', 'panel.html' ); } }, From 3b3e1a87f39d48a8292e81737b1203d491e61682 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Thu, 17 Feb 2022 12:05:51 -0800 Subject: [PATCH 2/2] Update test timeout --- dwds/test/debug_extension_test.dart | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/dwds/test/debug_extension_test.dart b/dwds/test/debug_extension_test.dart index 9f336b46f..a181ad486 100644 --- a/dwds/test/debug_extension_test.dart +++ b/dwds/test/debug_extension_test.dart @@ -31,6 +31,12 @@ import 'fixtures/utilities.dart'; // See go/extension-identification. final context = TestContext(); + +// TODO(elliette): Instead of setting a time to load, check for element on page. +// See: https://github.com/dart-lang/webdev/issues/1512 +// Time for Dart DevTools to load, in seconds. +final devToolsLoadTime = const Duration(seconds: 4); + void main() async { for (var useSse in [true, false]) { group(useSse ? 'SSE' : 'WebSockets', () { @@ -42,7 +48,7 @@ void main() async { 'expression': 'fakeClick()', }); // Wait for DevTools to actually open. - await Future.delayed(const Duration(seconds: 2)); + await Future.delayed(devToolsLoadTime); }); tearDown(() async { @@ -70,7 +76,7 @@ void main() async { await context.extensionConnection.sendCommand('Runtime.evaluate', { 'expression': 'fakeClick()', }); - await Future.delayed(const Duration(seconds: 4)); + await Future.delayed(devToolsLoadTime); var windows = await context.webDriver.windows.toList(); await context.webDriver.driver.switchTo.window(windows.last); expect(await context.webDriver.title, 'Dart DevTools'); @@ -122,7 +128,7 @@ void main() async { 'expression': 'fakeClick()', }); // Wait for DevTools to actually open. - await Future.delayed(const Duration(seconds: 2)); + await Future.delayed(devToolsLoadTime); }); tearDown(() async { @@ -148,7 +154,7 @@ void main() async { await context.extensionConnection.sendCommand('Runtime.evaluate', { 'expression': 'fakeClick()', }); - await Future.delayed(const Duration(seconds: 4)); + await Future.delayed(devToolsLoadTime); var windows = await context.webDriver.windows.toList(); await context.webDriver.driver.switchTo.window(windows.last); expect(await context.webDriver.title, 'Dart DevTools');