Skip to content

Commit dcffd01

Browse files
author
Anna Gringauze
authored
Fix flakes in tests due to race condition on finding a free port (#1515)
1 parent 8224dda commit dcffd01

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

dwds/test/events_test.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import 'package:dwds/src/connections/debug_connection.dart';
1111
import 'package:dwds/src/events.dart';
1212
import 'package:dwds/src/services/chrome_proxy_service.dart';
1313
import 'package:dwds/src/utilities/shared.dart';
14-
import 'package:http_multi_server/http_multi_server.dart';
1514
import 'package:test/test.dart';
1615
import 'package:vm_service/vm_service.dart';
1716
import 'package:webdriver/async_core.dart';
@@ -33,7 +32,7 @@ void main() {
3332

3433
setUp(() async {
3534
setCurrentLogWriter();
36-
server = await HttpMultiServer.bind('localhost', 0);
35+
server = await startHttpServer('localhost', port: 0);
3736
});
3837

3938
tearDown(() async {

dwds/test/fixtures/server.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import 'package:dds/devtools_server.dart';
1111
import 'package:dwds/data/build_result.dart';
1212
import 'package:dwds/dwds.dart';
1313
import 'package:dwds/src/utilities/shared.dart';
14-
import 'package:http_multi_server/http_multi_server.dart';
1514
import 'package:logging/logging.dart';
1615
import 'package:shelf/shelf.dart';
1716
import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
@@ -123,7 +122,7 @@ class TestServer {
123122
}
124123
: null);
125124

126-
var server = await HttpMultiServer.bind('localhost', port);
125+
var server = await startHttpServer('localhost', port: port);
127126
var cascade = Cascade();
128127

129128
cascade = cascade.add(dwds.handler).add(assetHandler);

0 commit comments

Comments
 (0)