Skip to content

Commit ab620d1

Browse files
authored
updates to be forward compatible with changes to package:shelf_web_socket (#2539)
* updates to be forward compatible with changes to package:shelf_web_socket * update built artifacts
1 parent 8fddd3d commit ab620d1

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

dwds/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 24.2.1-wip
2+
3+
- Update to be forward compatible with changes to `package:shelf_web_socket`.
4+
15
## 24.2.0
26

37
- Consolidate `FrontendServerDdcStrategyProvider` and `FrontendServerRequireStrategyProvider` under a shared parent class. - [#2517](https://github.com/dart-lang/webdev/issues/2517)

dwds/lib/src/handlers/socket_connections.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class WebSocketSocketHandler extends SocketHandler {
104104

105105
WebSocketSocketHandler() {
106106
_handler = webSocketHandler(
107-
(WebSocketChannel channel) =>
107+
(WebSocketChannel channel, _) =>
108108
_connectionsStream.add(WebSocketConnection(channel)),
109109
);
110110
}

dwds/lib/src/services/debug_service.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ int _clientsConnected = 0;
3434

3535
Logger _logger = Logger('DebugService');
3636

37-
void Function(WebSocketChannel) _createNewConnectionHandler(
37+
void Function(WebSocketChannel, String?) _createNewConnectionHandler(
3838
ChromeProxyService chromeProxyService,
3939
ServiceExtensionRegistry serviceExtensionRegistry, {
4040
void Function(Map<String, Object>)? onRequest,
4141
void Function(Map<String, Object?>)? onResponse,
4242
}) {
43-
return (webSocket) {
43+
return (webSocket, subprotocol) {
4444
final responseController = StreamController<Map<String, Object?>>();
4545
webSocket.sink.addStream(
4646
responseController.stream.map((response) {

dwds/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 24.2.0
3+
version: 24.2.1-wip
44
description: >-
55
A service that proxies between the Chrome debug protocol and the Dart VM
66
service protocol.

dwds/test/build/ensure_version_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ void main() {
1818
expect(
1919
Version.parse(packageVersion),
2020
pubspec.version,
21-
reason: 'Please run `pub run build_runner build '
21+
reason: 'Please run `dart run build_runner build '
2222
'--build-filter=lib/src/version.dart` to update the version.',
2323
);
2424
});

0 commit comments

Comments
 (0)