Skip to content

Commit 63e09e5

Browse files
authored
Remove unused scripting code and permission (#2294)
1 parent 8c22555 commit 63e09e5

File tree

2 files changed

+1
-39
lines changed

2 files changed

+1
-39
lines changed

dwds/debug_extension_mv3/web/manifest_mv3.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,7 @@
1717
"https://cider-v-test.corp.google.com/*"
1818
]
1919
},
20-
"permissions": [
21-
"debugger",
22-
"notifications",
23-
"scripting",
24-
"storage",
25-
"webNavigation"
26-
],
20+
"permissions": ["debugger", "notifications", "storage", "webNavigation"],
2721
"host_permissions": ["<all_urls>"],
2822
"background": {
2923
"service_worker": "background.dart.js"

dwds/debug_extension_mv3/web/utils.dart

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import 'dart:js_util';
1111
import 'package:js/js.dart';
1212

1313
import 'chrome_api.dart';
14-
import 'logger.dart';
1514

1615
Future<Tab> createTab(String url, {bool inNewWindow = false}) {
1716
final completer = Completer<Tab>();
@@ -88,23 +87,6 @@ void displayNotification(
8887
);
8988
}
9089

91-
Future<bool> injectScript(String scriptName, {required int tabId}) async {
92-
if (isMV3) {
93-
await promiseToFuture(
94-
_executeScriptMV3(
95-
_InjectDetails(
96-
target: Target(tabId: tabId),
97-
files: [scriptName],
98-
),
99-
),
100-
);
101-
return true;
102-
} else {
103-
debugWarn('Script injection is only supported in Manifest V3.');
104-
return false;
105-
}
106-
}
107-
10890
void onExtensionIconClicked(void Function(Tab) callback) {
10991
if (isMV3) {
11092
_onExtensionIconClickedMV3(callback);
@@ -189,17 +171,3 @@ class IconInfo {
189171
external String get path;
190172
external factory IconInfo({required String path});
191173
}
192-
193-
@JS('chrome.scripting.executeScript')
194-
external Object _executeScriptMV3(_InjectDetails details);
195-
196-
@JS()
197-
@anonymous
198-
class _InjectDetails {
199-
external Target get target;
200-
external List<String>? get files;
201-
external factory _InjectDetails({
202-
Target target,
203-
List<String>? files,
204-
});
205-
}

0 commit comments

Comments
 (0)