Skip to content

Commit 2ed81fd

Browse files
committed
Defer changes in v3.3.0-wip to v4.0.0-wip
1 parent 94c0539 commit 2ed81fd

File tree

6 files changed

+21
-16
lines changed

6 files changed

+21
-16
lines changed

dwds/lib/src/debugging/location.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class DartLocation {
7878
int get hashCode => Object.hashAll([uri, line, column]);
7979

8080
@override
81-
bool operator ==(Object? other) {
81+
bool operator ==(Object other) {
8282
if (other is! DartLocation) {
8383
return false;
8484
}

frontend_server_client/CHANGELOG.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
## 4.0.0-wip
22

3+
- Update Dart SDK constraint to `^3.0.0`.
4+
- Support changes in the SDK layout for Dart 3.0.
35
- By default, start the frontend server from the AOT snapshot shipped in the
46
Dart SDK.
57
- Throw an `ArgumentError` when `FrontendServerClient.start` is called with the
68
`frontendServerPath` argument omitted and the `debug` argument set to true.
7-
8-
## 3.3.0
9-
10-
- Update Dart SDK constraint to `>=3.0.0 <4.0.0`.
11-
- Support changes in the SDK layout for Dart 3.0.
9+
- Update `package:vm_service` constraint to `^14.0.0`.
1210

1311
## 3.2.0
1412

frontend_server_client/lib/src/frontend_server_client.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ class FrontendServerClient {
103103
feServer = await Process.start(
104104
Platform.resolvedExecutable,
105105
<String>[
106-
if (debug) '--observe',
107-
frontendServerPath,
108-
...commonArguments,
109-
],
106+
if (debug) '--observe',
107+
frontendServerPath,
108+
...commonArguments,
109+
],
110110
);
111111
} else if (File(_feServerAotSnapshotPath).existsSync()) {
112112
if (debug) {
@@ -123,10 +123,10 @@ class FrontendServerClient {
123123
feServer = await Process.start(
124124
Platform.resolvedExecutable,
125125
<String>[
126-
if (debug) '--observe',
127-
_feServerAppJitSnapshotPath,
128-
...commonArguments,
129-
],
126+
if (debug) '--observe',
127+
_feServerAppJitSnapshotPath,
128+
...commonArguments,
129+
],
130130
);
131131
}
132132
var feServerStdoutLines = StreamQueue(feServer.stdout

frontend_server_client/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ dev_dependencies:
2020
test: ^1.16.0
2121
test_descriptor: ^2.0.0
2222
test_process: ^2.0.0
23-
vm_service: ^8.0.0
23+
vm_service: ^14.0.0

frontend_server_common/lib/src/frontend_server_client.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ class ResidentCompiler {
398398

399399
_logger.info(args.join(' '));
400400
final workingDirectory = projectDirectory.toFilePath();
401-
_server = await Process.start(sdkLayout.dartPath, args,
401+
_server = await Process.start(sdkLayout.dartAotRuntimePath, args,
402402
workingDirectory: workingDirectory);
403403

404404
var server = _server!;

test_common/lib/test_sdk_layout.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@ class TestSdkLayout {
9090
'bin',
9191
Platform.isWindows ? 'dart.exe' : 'dart',
9292
),
93+
dartAotRuntimePath: p.join(
94+
sdkLayout.sdkDirectory,
95+
'bin',
96+
Platform.isWindows ? 'dartaotruntime.exe' : 'dartaotruntime',
97+
),
9398
frontendServerSnapshotPath: p.join(
9499
sdkLayout.sdkDirectory,
95100
'bin',
@@ -137,6 +142,7 @@ class TestSdkLayout {
137142
final String stackTraceMapperPath;
138143

139144
final String dartPath;
145+
final String dartAotRuntimePath;
140146
final String frontendServerSnapshotPath;
141147
final String dartdevcSnapshotPath;
142148
final String kernelWorkerSnapshotPath;
@@ -155,6 +161,7 @@ class TestSdkLayout {
155161
required this.requireJsPath,
156162
required this.stackTraceMapperPath,
157163
required this.dartPath,
164+
required this.dartAotRuntimePath,
158165
required this.frontendServerSnapshotPath,
159166
required this.dartdevcSnapshotPath,
160167
required this.kernelWorkerSnapshotPath,

0 commit comments

Comments
 (0)