[dartfix] Bump pedantic dep to v1.8.0 and cleanup lint violations

This version added three new lints:
* prefer_iterable_whereType
* unnecessary_const
* unnecessary_new

Change-Id: I99b5f3df86a0243091699cd2f3e1d38b5c5a9216
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108381
Reviewed-by: Dan Rubel <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

Author: nshahan

pkg/dartfix/analysis_options.yaml

@@ -1,4 +1,4 @@
-include: package:pedantic/analysis_options.1.7.0.yaml
+include: package:pedantic/analysis_options.1.8.0.yaml
 
 linter:
   rules:

pkg/dartfix/bin/dartfix.dart

@@ -7,7 +7,7 @@ import 'package:dartfix/src/driver.dart';
 
 /// The entry point for dartfix.
 void main(List<String> args) async {
-  Driver starter = new Driver();
+  Driver starter = Driver();
 
   // Wait for the starter to complete.
   await starter.start(args);

pkg/dartfix/lib/handler/analysis_complete_handler.dart

@@ -25,7 +25,7 @@ mixin AnalysisCompleteHandler on NotificationHandler {
   }
 
   Future<void> analysisComplete() {
-    _analysisComplete ??= new Completer<void>();
+    _analysisComplete ??= Completer<void>();
     return _analysisComplete.future;
   }
 }

pkg/dartfix/lib/listener/bad_message_listener.dart

@@ -16,7 +16,7 @@ mixin BadMessageListener on ServerListener {
       _receivedBadDataFromServer = true;
       // Give the server 1 second to continue outputting bad data
       // such as outputting a stacktrace.
-      new Future.delayed(new Duration(seconds: 1), () {
+      Future.delayed(Duration(seconds: 1), () {
         throw '$prefix $details';
       });
     }

pkg/dartfix/lib/listener/timed_listener.dart

@@ -8,7 +8,7 @@ import 'package:analysis_server_client/listener/server_listener.dart';
 /// to each logged interaction with the server.
 mixin TimedListener on ServerListener {
   /// Stopwatch that we use to generate timing information for debug output.
-  Stopwatch _time = new Stopwatch();
+  Stopwatch _time = Stopwatch();
 
   /// The [currentElapseTime] at which the last communication was received from
   /// the server or `null` if no communication has been received.

pkg/dartfix/lib/src/driver.dart

@@ -50,7 +50,7 @@ class Driver {
     }
     if (checkIfChangesShouldBeApplied(result)) {
       for (SourceFileEdit fileEdit in result.edits) {
-        final file = new File(fileEdit.file);
+        final file = File(fileEdit.file);
         String code = file.existsSync() ? file.readAsStringSync() : '';
         code = SourceEdit.applySequence(code, fileEdit.edits);
         await file.writeAsString(code);
@@ -80,7 +80,7 @@ class Driver {
   /// server being run and return `true` if they are.
   /// Display an error message and return `false` if not.
   bool checkIfSelectedOptionsAreSupported(Options options) {
-    if (handler.serverProtocolVersion.compareTo(new Version(1, 22, 2)) >= 0) {
+    if (handler.serverProtocolVersion.compareTo(Version(1, 22, 2)) >= 0) {
       return true;
     }
     if (options.excludeFixes.isNotEmpty) {
@@ -108,7 +108,7 @@ class Driver {
     logger.trace('Requesting fixes');
     Future isAnalysisComplete = handler.analysisComplete();
 
-    final params = new EditDartfixParams(options.targets);
+    final params = EditDartfixParams(options.targets);
     if (options.excludeFixes.isNotEmpty) {
       params.excludedFixes = options.excludeFixes;
     }
@@ -128,18 +128,18 @@ class Driver {
     await isAnalysisComplete;
 
     progress.finish(showTiming: true);
-    ResponseDecoder decoder = new ResponseDecoder(null);
+    ResponseDecoder decoder = ResponseDecoder(null);
     return EditDartfixResult.fromJson(decoder, 'result', json);
   }
 
   void showDescriptions(String title, List<DartFixSuggestion> suggestions) {
     if (suggestions.isNotEmpty) {
       logger.stdout('');
       logger.stdout(ansi.emphasized('$title:'));
-      List<DartFixSuggestion> sorted = new List.from(suggestions)
+      List<DartFixSuggestion> sorted = List.from(suggestions)
         ..sort(compareSuggestions);
       for (DartFixSuggestion suggestion in sorted) {
-        final msg = new StringBuffer();
+        final msg = StringBuffer();
         msg.write('  ${toSentenceFragment(suggestion.description)}');
         final loc = suggestion.location;
         if (loc != null) {
@@ -179,12 +179,12 @@ Analysis Details:
 
   Future<EditGetDartfixInfoResult> showFixes({Progress progress}) async {
     Map<String, dynamic> json = await server.send(
-        EDIT_REQUEST_GET_DARTFIX_INFO, new EditGetDartfixInfoParams().toJson());
+        EDIT_REQUEST_GET_DARTFIX_INFO, EditGetDartfixInfoParams().toJson());
     progress?.finish(showTiming: true);
-    ResponseDecoder decoder = new ResponseDecoder(null);
+    ResponseDecoder decoder = ResponseDecoder(null);
     final result = EditGetDartfixInfoResult.fromJson(decoder, 'result', json);
 
-    final fixes = new List<DartFix>.from(result.fixes)
+    final fixes = List<DartFix>.from(result.fixes)
       ..sort((f1, f2) => f1.name.compareTo(f2.name));
 
     logger.stdout('''
@@ -216,8 +216,8 @@ These fixes are NOT automatically applied, but may be enabled using --$includeOp
     targets = options.targets;
     context = testContext ?? options.context;
     logger = testLogger ?? options.logger;
-    server = new Server(listener: new _Listener(logger));
-    handler = new _Handler(this);
+    server = Server(listener: _Listener(logger));
+    handler = _Handler(this);
 
     // Start showing progress before we start the analysis server.
     Progress progress;
@@ -291,10 +291,10 @@ analysis server
     logger.trace('');
     logger.trace('Setup analysis');
     await server.send(SERVER_REQUEST_SET_SUBSCRIPTIONS,
-        new ServerSetSubscriptionsParams([ServerService.STATUS]).toJson());
+        ServerSetSubscriptionsParams([ServerService.STATUS]).toJson());
     await server.send(
         ANALYSIS_REQUEST_SET_ANALYSIS_ROOTS,
-        new AnalysisSetAnalysisRootsParams(
+        AnalysisSetAnalysisRootsParams(
           options.targets,
           const [],
         ).toJson());

pkg/dartfix/lib/src/options.dart

@@ -67,7 +67,7 @@ class Options {
   }
 
   static Options parse(List<String> args, Context context, Logger logger) {
-    final parser = new ArgParser(allowTrailingOptions: true)
+    final parser = ArgParser(allowTrailingOptions: true)
       ..addSeparator('Choosing fixes to be applied:')
       ..addMultiOption(includeOption,
           abbr: 'i', help: 'Include a specific fix.', valueHelp: 'name-of-fix')
@@ -106,26 +106,26 @@ class Options {
           help: 'Use ansi colors when printing messages.',
           defaultsTo: Ansi.terminalSupportsAnsi);
 
-    context ??= new Context();
+    context ??= Context();
 
     ArgResults results;
     try {
       results = parser.parse(args);
     } on FormatException catch (e) {
-      logger ??= new Logger.standard(ansi: new Ansi(Ansi.terminalSupportsAnsi));
+      logger ??= Logger.standard(ansi: Ansi(Ansi.terminalSupportsAnsi));
       logger.stderr(e.message);
       _showUsage(parser, logger);
       context.exit(15);
     }
 
-    Options options = new Options._fromArgs(context, results);
+    Options options = Options._fromArgs(context, results);
 
     if (logger == null) {
       if (options.verbose) {
-        logger = new Logger.verbose();
+        logger = Logger.verbose();
       } else {
-        logger = new Logger.standard(
-            ansi: new Ansi(
+        logger = Logger.standard(
+            ansi: Ansi(
           options.useColor != null
               ? options.useColor
               : Ansi.terminalSupportsAnsi,

pkg/dartfix/lib/src/util.dart

@@ -28,7 +28,7 @@ String findServerPath() {
     }
     String serverPath =
         path.join(parent, 'pkg', 'analysis_server', 'bin', 'server.dart');
-    if (new File(serverPath).existsSync()) {
+    if (File(serverPath).existsSync()) {
       return serverPath;
     }
     pathname = parent;

pkg/dartfix/pubspec.yaml

@@ -23,5 +23,5 @@ dependencies:
 
 dev_dependencies:
   analyzer: ^0.33.0
-  pedantic: ^1.7.0
+  pedantic: ^1.8.0
   test: ^1.3.0

pkg/dartfix/test/src/driver_exclude_test.dart

@@ -19,9 +19,9 @@ main() {
     exampleFile = findFile('pkg/dartfix/example/example.dart');
     exampleDir = exampleFile.parent;
 
-    final driver = new Driver();
-    final testContext = new TestContext();
-    final testLogger = new TestLogger(debug: _debug);
+    final driver = Driver();
+    final testContext = TestContext();
+    final testLogger = TestLogger(debug: _debug);
     String exampleSource = await exampleFile.readAsString();
 
     var args = ['-xuse-mixin', exampleDir.path];