Skip to content

Commit c62709e

Browse files
jakemac53commit-bot@chromium.org
authored andcommitted
Reland "update Glob in the sdk, also adds package:file to the sdk"
This reverts commit ce614d3. Original change's description: > Revert "update Glob in the sdk, also adds package:file to the sdk" > > This reverts commit 18b19db. > > Reason for revert: Breaks Flutter 3H/Golem. Tried making an appropriate patch for 3H that would pull file into its dependencies (see https://dart-review.googlesource.com/c/sdk/+/173960/), but that still failed, so reverting. > > Original change's description: > > update Glob in the sdk, also adds package:file to the sdk > > > > Change-Id: Ia8628c28bfaf6343c19eecfef391339968cd57e9 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172063 > > Commit-Queue: Jake Macdonald <[email protected]> > > Reviewed-by: Nate Bosch <[email protected]> > > [email protected],[email protected] > > Change-Id: I0616e3df7505f348edeefee40cbaf4adc59487cd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173963 > Reviewed-by: Tess Strickland <[email protected]> > Commit-Queue: Tess Strickland <[email protected]> [email protected],[email protected],[email protected] # Not skipping CQ checks because this is a reland. Change-Id: Ia85fe3b81214ca4ef2bed8e08ecc1b617927a579 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173981 Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Jake Macdonald <[email protected]>
1 parent 4fc797d commit c62709e

File tree

7 files changed

+37
-8
lines changed

7 files changed

+37
-8
lines changed

.dart_tool/package_config.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,12 @@
257257
"packageUri": "lib/",
258258
"languageVersion": "2.12"
259259
},
260+
{
261+
"name": "file",
262+
"rootUri": "../third_party/pkg/file/packages/file",
263+
"packageUri": "lib/",
264+
"languageVersion": "2.12"
265+
},
260266
{
261267
"name": "fixnum",
262268
"rootUri": "../third_party/pkg/fixnum",
@@ -284,7 +290,7 @@
284290
"name": "glob",
285291
"rootUri": "../third_party/pkg/glob",
286292
"packageUri": "lib/",
287-
"languageVersion": "2.2"
293+
"languageVersion": "2.12"
288294
},
289295
{
290296
"name": "html",

DEPS

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ vars = {
104104
"dartdoc_rev" : "d79877d0764ce23ffea7055049f8da5dffce0308",
105105
"ffi_rev": "a5d4232cd38562c75a3ed847baa340e399538028",
106106
"fixnum_rev": "16d3890c6dc82ca629659da1934e412292508bba",
107-
"glob_rev": "e9f4e6b7ae8abe5071461cf8f47191bb19cf7ef6",
107+
"file_rev": "0e09370f581ab6388d46fda4cdab66638c0171a1",
108+
"glob_rev": "7c0ef8d4fa086f6b185c4dd724b700e7d7ad8f79",
108109
"html_rev": "22f17e97fedeacaa1e945cf84d8016284eed33a6",
109110
"http_io_rev": "2fa188caf7937e313026557713f7feffedd4978b",
110111
"http_multi_server_rev" : "f1d1c9c024a293ab0a0e16f8b7632e87c708b448",
@@ -335,6 +336,9 @@ deps = {
335336
Var("dart_git") + "ffi.git" + "@" + Var("ffi_rev"),
336337
Var("dart_root") + "/third_party/pkg/fixnum":
337338
Var("dart_git") + "fixnum.git" + "@" + Var("fixnum_rev"),
339+
Var("dart_root") + "/third_party/pkg/file":
340+
Var("dart_git") + "external/github.com/google/file.dart/"
341+
+ "@" + Var("file_rev"),
338342
Var("dart_root") + "/third_party/pkg/glob":
339343
Var("dart_git") + "glob.git" + "@" + Var("glob_rev"),
340344
Var("dart_root") + "/third_party/pkg/html":

pkg/test_runner/lib/src/browser_controller.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ class Safari extends Browser {
298298
// We run killAndResetSafari in a Zone as opposed to running an external
299299
// process. The Zone allows us to collect its output, and protect the rest
300300
// of the test infrastructure against errors in it.
301-
runZoned(zoneWrapper,
302-
zoneSpecification: specification, onError: handleUncaughtError);
301+
runZonedGuarded(zoneWrapper, handleUncaughtError,
302+
zoneSpecification: specification);
303303

304304
try {
305305
await completer.future;

pkg/test_runner/lib/src/test_suite.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,6 @@ class StandardTestSuite extends TestSuite {
862862

863863
print("Cannot create URL for path $file. Not in build or dart directory.");
864864
exit(1);
865-
throw "unreachable";
866865
}
867866

868867
String _uriForBrowserTest(String pathComponent) {

pkg/test_runner/pubspec.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,14 @@ dependencies:
2222
dev_dependencies:
2323
expect:
2424
path: ../expect
25-
glob:
26-
path: ../../third_party/pkg/glob
25+
file: any
26+
glob: any
2727
dependency_overrides:
2828
# Other packages in the dependency graph have normal hosted dependencies on
2929
# this, so just override it to force the local one.
3030
args:
3131
path: ../../third_party/pkg/args
32+
file:
33+
path: ../../third_party/pkg/file/packages/file
34+
glob:
35+
path: ../../third_party/pkg/glob

pkg/test_runner/tool/update_static_error_tests.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
import 'dart:io';
88

99
import 'package:args/args.dart';
10+
import 'package:file/file.dart' as pkg_file;
1011
import 'package:glob/glob.dart';
12+
import 'package:glob/list_local_fs.dart';
1113
import 'package:path/path.dart' as p;
1214

1315
import 'package:test_runner/src/command_output.dart';
@@ -130,7 +132,7 @@ Future<void> main(List<String> args) async {
130132
for (var entry in glob.listSync(root: root)) {
131133
if (!entry.path.endsWith(".dart")) continue;
132134

133-
if (entry is File) {
135+
if (entry is pkg_file.File) {
134136
await _processFile(entry,
135137
dryRun: dryRun,
136138
remove: removeSources,
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
diff --git a/DEPS b/DEPS
2+
index 17f3f9f68..39b78c735 100644
3+
--- a/DEPS
4+
+++ b/DEPS
5+
@@ -198,6 +198,9 @@ deps = {
6+
'src/third_party/dart/third_party/pkg/ffi':
7+
Var('dart_git') + '/ffi.git@a5d4232cd38562c75a3ed847baa340e399538028',
8+
9+
+ 'src/third_party/dart/third_party/pkg/file':
10+
+ Var('dart_git') + '/external/github.com/google/file.dart@0e09370f581ab6388d46fda4cdab66638c0171a1',
11+
+
12+
'src/third_party/dart/third_party/pkg/fixnum':
13+
Var('dart_git') + '/fixnum.git@16d3890c6dc82ca629659da1934e412292508bba',
14+

0 commit comments

Comments
 (0)