[vm, arm64] Add missing store barrier to PushArrayOfArguments.

rmacnak-google · commit-bot@chromium.org · commit bab399b5ae6c · 2019-09-17T22:39:00.000Z
Bug: #38359 Change-Id: I43d13c9188e55726b70281e2499b42b72ddbb86a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117588 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
diff --git a/runtime/vm/compiler/stub_code_compiler_arm64.cc b/runtime/vm/compiler/stub_code_compiler_arm64.cc
@@ -876,7 +876,7 @@ static void PushArrayOfArguments(Assembler* assembler) {
   __ AddImmediate(R1, -target::kWordSize);
   __ AddImmediate(R3, target::kWordSize);
   __ AddImmediateSetFlags(R2, R2, -target::ToRawSmi(1));
-  __ str(R7, Address(R3, -target::kWordSize));
+  __ StoreIntoObject(R0, Address(R3, -target::kWordSize), R7);
   __ b(&loop, GE);
   __ Bind(&loop_exit);
 }

Original file line number	Diff line number	Diff line change
`@@ -876,7 +876,7 @@ static void PushArrayOfArguments(Assembler* assembler) {`
`876`	`876`	`__ AddImmediate(R1, -target::kWordSize);`
`877`	`877`	`__ AddImmediate(R3, target::kWordSize);`
`878`	`878`	`__ AddImmediateSetFlags(R2, R2, -target::ToRawSmi(1));`
`879`		`- __ str(R7, Address(R3, -target::kWordSize));`
	`879`	`+ __ StoreIntoObject(R0, Address(R3, -target::kWordSize), R7);`
`880`	`880`	`__ b(&loop, GE);`
`881`	`881`	`__ Bind(&loop_exit);`
`882`	`882`	`}`