[vm/concurrency] Fix asan memory leak caused by longjmp over std::function<> objects

This is a follow-up to 38c6152

Change-Id: I33a116e5b13325a6dd5fe27d6dfe87764ffd6a3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117781
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>

Author: mkustermann

runtime/vm/compiler/jit/compiler.cc

@@ -647,18 +647,15 @@ RawCode* CompileParsedFunctionHelper::Compile(CompilationPipeline* pipeline) {
       {
         TIMELINE_DURATION(thread(), CompilerVerbose, "FinalizeCompilation");
 
-        auto mutator_fun = [&]() {
-          *result =
-              FinalizeCompilation(&assembler, &graph_compiler, flow_graph);
-        };
-        auto bg_compiler_fun = [&]() {
-          if (Compiler::IsBackgroundCompilation()) {
-            CheckIfBackgroundCompilerIsBeingStopped(optimized());
-          }
+        auto install_code_fun = [&]() {
           *result =
               FinalizeCompilation(&assembler, &graph_compiler, flow_graph);
         };
 
+        if (Compiler::IsBackgroundCompilation()) {
+          CheckIfBackgroundCompilerIsBeingStopped(optimized());
+        }
+
         // We have to ensure no mutators are running, because:
         //
         //   a) We allocate an instructions object, which might cause us to
@@ -673,7 +670,7 @@ RawCode* CompileParsedFunctionHelper::Compile(CompilationPipeline* pipeline) {
         //      those writes are observed atomically.
         //
         thread()->isolate_group()->RunWithStoppedMutators(
-            mutator_fun, bg_compiler_fun, /*use_force_growth=*/true);
+            install_code_fun, install_code_fun, /*use_force_growth=*/true);
 
         // We notify code observers after finalizing the code in order to be
         // outside a [SafepointOperationScope].