Skip to content

Commit 93793a4

Browse files
stereotype441commit-bot@chromium.org
authored andcommitted
Migration: add tests to document missing required keyword functionality.
See #38461 and #38462. Change-Id: I94da796e0d21578c9838ae0eb9c477f4a21e054e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117771 Reviewed-by: Samuel Rawlins <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 8acd1fe commit 93793a4

File tree

1 file changed

+25
-0
lines changed

1 file changed

+25
-0
lines changed

pkg/nnbd_migration/test/api_test.dart

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,17 @@ abstract class _ProvisionalApiTestBase extends AbstractContextTest {
7676

7777
/// Mixin containing test cases for the provisional API.
7878
mixin _ProvisionalApiTestCases on _ProvisionalApiTestBase {
79+
@FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/38461')
80+
test_add_required() async {
81+
var content = '''
82+
int f({String s}) => s.length;
83+
''';
84+
var expected = '''
85+
int f({required String s}) => s.length;
86+
''';
87+
await _checkSingleFileChanges(content, expected);
88+
}
89+
7990
test_assign_null_to_generic_type() async {
8091
var content = '''
8192
main() {
@@ -469,6 +480,20 @@ class Key {}
469480
await _checkSingleFileChanges(content, expected);
470481
}
471482

483+
@FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/38462')
484+
test_convert_required() async {
485+
addMetaPackage();
486+
var content = '''
487+
import 'package:meta/meta.dart';
488+
void f({@required String s}) {}
489+
''';
490+
var expected = '''
491+
import 'package:meta/meta.dart';
492+
void f({required String s}) {}
493+
''';
494+
await _checkSingleFileChanges(content, expected);
495+
}
496+
472497
test_data_flow_assignment_field() async {
473498
var content = '''
474499
class C {

0 commit comments

Comments
 (0)