Treat DownCastComposite as a StaticWarning, not a StaticTypeWarning.

munificent · munificent · commit 8922198e78b3 · 2016-03-23T15:36:00.000-07:00
This works around the fact that strong mode promotes all StaticTypeWarnings to errors, but we don't want to do that for this strong-mode-specific warning. See: #26026 R=jmesserly@google.com, vsm@google.com Review URL: https://codereview.chromium.org/1833553002 .
diff --git a/pkg/analyzer/lib/src/task/strong/info.dart b/pkg/analyzer/lib/src/task/strong/info.dart
@@ -170,7 +170,7 @@ class DownCastComposite extends DownCast {
   @override
   String get name => 'STRONG_MODE_DOWN_CAST_COMPOSITE';
 
-  toErrorCode() => new StaticTypeWarningCode(name, message);
+  toErrorCode() => new StaticWarningCode(name, message);
 }
 
 /// A down cast to a non-ground type.  These behave differently from standard

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ class DownCastComposite extends DownCast {`
`170`	`170`	`@override`
`171`	`171`	`String get name => 'STRONG_MODE_DOWN_CAST_COMPOSITE';`
`172`	`172`
`173`		`- toErrorCode() => new StaticTypeWarningCode(name, message);`
	`173`	`+ toErrorCode() => new StaticWarningCode(name, message);`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`/// A down cast to a non-ground type. These behave differently from standard`