Skip to content

Commit 4b6ab33

Browse files
a-sivacommit-bot@chromium.org
authored andcommitted
[SDK] Reland: Remove dart:profiler library which has been deprecated since Dart 1.2
and remove all references to it in tests and the SDK build scripts. Change-Id: I728770c460042596ddd14efecdc52bcf0580f592 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117584 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Siva Annamalai <[email protected]>
1 parent 30d2433 commit 4b6ab33

19 files changed

+194
-251
lines changed

pkg/front_end/testcases/general/export_test.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44

55
/// Test that exports are serialized in platform.dill.
66
7-
// Note: "dart:profiler" exports UserTag from "dart:developer". This is
8-
// somewhat brittle and we should extend this test framework to be able to deal
9-
// with multiple .dill files.
10-
import 'dart:profiler' show UserTag;
7+
// This is somewhat brittle and we should extend this test framework to be
8+
// able to deal with multiple .dill files.
9+
import 'dart:developer' show UserTag;
1110

1211
export 'dart:core' show print;
1312

pkg/front_end/testcases/general/export_test.dart.outline.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import "dart:core" as core;
44
additionalExports = (core::print)
55

66

7-
import "dart:profiler";
7+
import "dart:developer";
88
export "dart:core";
99

1010
static method main() → dynamic

pkg/front_end/testcases/general/export_test.dart.strong.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import "dart:developer" as dev;
55
additionalExports = (core::print)
66

77

8-
import "dart:profiler";
8+
import "dart:developer";
99
export "dart:core";
1010

1111
static method main() → dynamic {

pkg/front_end/testcases/general/export_test.dart.strong.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import "dart:developer" as dev;
55
additionalExports = (core::print)
66

77

8-
import "dart:profiler";
8+
import "dart:developer";
99
export "dart:core";
1010

1111
static method main() → dynamic {

pkg/vm/lib/target/dart_runner.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,5 @@ class DartRunnerTarget extends VmTarget {
4545
];
4646

4747
@override
48-
List<String> get extraRequiredLibrariesPlatform => const <String>[
49-
'dart:profiler',
50-
];
48+
List<String> get extraRequiredLibrariesPlatform => const <String>[];
5149
}

pkg/vm/lib/target/flutter.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@ class FlutterTarget extends VmTarget {
4848
];
4949

5050
@override
51-
List<String> get extraRequiredLibrariesPlatform => const <String>[
52-
'dart:profiler',
53-
];
51+
List<String> get extraRequiredLibrariesPlatform => const <String>[];
5452

5553
@override
5654
void performPreConstantEvaluationTransformations(

pkg/vm/lib/target/flutter_runner.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,5 @@ class FlutterRunnerTarget extends VmTarget {
4646
];
4747

4848
@override
49-
List<String> get extraRequiredLibrariesPlatform => const <String>[
50-
'dart:profiler',
51-
];
49+
List<String> get extraRequiredLibrariesPlatform => const <String>[];
5250
}

pkg/vm/lib/target/vm.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ class VmTarget extends Target {
7777
];
7878

7979
@override
80-
List<String> get extraRequiredLibrariesPlatform => const <String>[
81-
'dart:profiler',
82-
];
80+
List<String> get extraRequiredLibrariesPlatform => const <String>[];
8381

8482
void _patchVmConstants(CoreTypes coreTypes) {
8583
// Fix Endian.host to be a const field equal to Endian.little instead of

runtime/vm/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import("../../sdk/lib/internal/internal_sources.gni")
1313
import("../../sdk/lib/isolate/isolate_sources.gni")
1414
import("../../sdk/lib/math/math_sources.gni")
1515
import("../../sdk/lib/mirrors/mirrors_sources.gni")
16-
import("../../sdk/lib/profiler/profiler_sources.gni")
1716
import("../../sdk/lib/typed_data/typed_data_sources.gni")
1817
import("../../sdk/lib/vmservice/vmservice_sources.gni")
1918
import("../../sdk/lib/wasm/wasm_sources.gni")

runtime/vm/bootstrap_natives.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,6 @@ void Bootstrap::SetupNativeResolver() {
127127
library.set_native_entry_symbol_resolver(symbol_resolver);
128128
#endif
129129

130-
library = Library::ProfilerLibrary();
131-
ASSERT(!library.IsNull());
132-
library.set_native_entry_resolver(resolver);
133-
library.set_native_entry_symbol_resolver(symbol_resolver);
134-
135130
library = Library::TypedDataLibrary();
136131
ASSERT(!library.IsNull());
137132
library.set_native_entry_resolver(resolver);

0 commit comments

Comments
 (0)