Skip to content

Commit 397c7e4

Browse files
alexmarkovcommit-bot@chromium.org
authored andcommitted
Revert "[vm/bytecode] Enable bytecode compiler by default in Dart SDK"
This reverts commit bcca3c4. Reason for revert: Failures on vm-kernel-reload-linux-release-x64 bot. Original change's description: > [vm/bytecode] Enable bytecode compiler by default in Dart SDK > > Change-Id: Ica9afac673e294734255a9fa8802ec05c2dde24c > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110551 > Reviewed-by: Régis Crelier <[email protected]> > Reviewed-by: Siva Annamalai <[email protected]> > Commit-Queue: Alexander Markov <[email protected]> [email protected],[email protected],[email protected],[email protected] Change-Id: I77ef8a0ccfafe6c6a5f309cd0e5ea7ca1b804846 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117927 Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent 108fe9c commit 397c7e4

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

runtime/runtime_args.gni

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ declare_args() {
8080
dart_component_kind = "static_library"
8181
}
8282

83-
# Controls whether the VM uses bytecode.
84-
dart_platform_bytecode = true
83+
# Whether the VM's platform dill file contains bytecode.
84+
dart_platform_bytecode = false
8585

8686
# Whether the VM includes the kernel service in all modes (debug, release,
8787
# product).

tools/gn.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -408,14 +408,9 @@ def parse_args(args):
408408
other_group.add_argument(
409409
'--bytecode',
410410
'-b',
411-
help='Use bytecode in Dart VM',
412-
default=True,
411+
help='Include bytecode in the VMs platform dill',
412+
default=False,
413413
action="store_true")
414-
other_group.add_argument(
415-
'--no-bytecode',
416-
help='Disable bytecode in Dart VM',
417-
dest='bytecode',
418-
action="store_false")
419414
other_group.add_argument(
420415
'--clang', help='Use Clang', default=True, action='store_true')
421416
other_group.add_argument(

0 commit comments

Comments
 (0)