Add UNDEFINED_EXTENSION_OPERATOR.

[email protected]

Change-Id: I5370c9cab5968e520266085e6060f29f42cbedef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118469
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analyzer/lib/error/error.dart

@@ -303,6 +303,7 @@ const List<ErrorCode> errorCodeValues = const [
   CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER_DEFAULT,
   CompileTimeErrorCode.UNDEFINED_EXTENSION_GETTER,
   CompileTimeErrorCode.UNDEFINED_EXTENSION_METHOD,
+  CompileTimeErrorCode.UNDEFINED_EXTENSION_OPERATOR,
   CompileTimeErrorCode.UNDEFINED_EXTENSION_SETTER,
   CompileTimeErrorCode.UNDEFINED_NAMED_PARAMETER,
   CompileTimeErrorCode.UNQUALIFIED_REFERENCE_TO_STATIC_MEMBER_OF_EXTENDED_TYPE,

pkg/analyzer/lib/src/error/codes.dart

@@ -3958,6 +3958,16 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
               "Try correcting the name to the name of an existing method, or "
               "defining a method named '{0}'.");
 
+  /**
+   * Parameters:
+   * 0: the name of the operator that is undefined
+   * 1: the name of the extension that was explicitly specified
+   */
+  static const CompileTimeErrorCode UNDEFINED_EXTENSION_OPERATOR =
+      const CompileTimeErrorCode('UNDEFINED_EXTENSION_OPERATOR',
+          "The operator '{0}' isn't defined for the extension '{1}'.",
+          correction: "Try defining the operator '{0}'.");
+
   /**
    * Parameters:
    * 0: the name of the setter that is undefined

pkg/analyzer/lib/src/generated/element_resolver.dart

@@ -1428,7 +1428,7 @@ class ElementResolver extends SimpleAstVisitor<void> {
         MethodElement member = element.getMethod(methodName);
         if (member == null) {
           _resolver.errorReporter.reportErrorForToken(
-              CompileTimeErrorCode.UNDEFINED_EXTENSION_METHOD,
+              CompileTimeErrorCode.UNDEFINED_EXTENSION_OPERATOR,
               node.operator,
               [methodName, element.name]);
         }

pkg/analyzer/test/src/diagnostics/test_all.dart

@@ -293,6 +293,7 @@ import 'undefined_class_boolean_test.dart' as undefined_class_boolean;
 import 'undefined_class_test.dart' as undefined_class;
 import 'undefined_extension_getter_test.dart' as undefined_extension_getter;
 import 'undefined_extension_method_test.dart' as undefined_extension_method;
+import 'undefined_extension_operator_test.dart' as undefined_extension_operator;
 import 'undefined_extension_setter_test.dart' as undefined_extension_setter;
 import 'undefined_getter_test.dart' as undefined_getter;
 import 'undefined_hidden_name_test.dart' as undefined_hidden_name;
@@ -527,6 +528,7 @@ main() {
     undefined_class.main();
     undefined_extension_getter.main();
     undefined_extension_method.main();
+    undefined_extension_operator.main();
     undefined_extension_setter.main();
     undefined_getter.main();
     undefined_hidden_name.main();

pkg/analyzer/test/src/diagnostics/undefined_extension_method_test.dart

@@ -51,32 +51,6 @@ f() {
     );
   }
 
-  test_operator_defined() async {
-    await assertNoErrorsInCode('''
-extension E on String {
-  void operator +(int offset) {}
-}
-f() {
-  E('a') + 1;
-}
-''');
-  }
-
-  test_operator_undefined() async {
-    await assertErrorsInCode('''
-extension E on String {}
-f() {
-  E('a') + 1;
-}
-''', [
-      error(CompileTimeErrorCode.UNDEFINED_EXTENSION_METHOD, 40, 1),
-    ]);
-    var binaryExpression = findNode.binary('+ 1');
-    assertElementNull(binaryExpression);
-    assertInvokeTypeNull(binaryExpression);
-    assertTypeDynamic(binaryExpression);
-  }
-
   test_static_withInference() async {
     await assertErrorsInCode('''
 extension E on Object {}

pkg/analyzer/test/src/diagnostics/undefined_extension_operator_test.dart

@@ -0,0 +1,50 @@
+// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analyzer/dart/analysis/features.dart';
+import 'package:analyzer/src/error/codes.dart';
+import 'package:analyzer/src/generated/engine.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import '../dart/resolution/driver_resolution.dart';
+
+main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(UndefinedExtensionMethodTest);
+  });
+}
+
+@reflectiveTest
+class UndefinedExtensionMethodTest extends DriverResolutionTest {
+  @override
+  AnalysisOptionsImpl get analysisOptions => AnalysisOptionsImpl()
+    ..contextFeatures = new FeatureSet.forTesting(
+        sdkVersion: '2.3.0', additionalFeatures: [Feature.extension_methods]);
+
+  test_binary_defined() async {
+    await assertNoErrorsInCode('''
+extension E on String {
+  void operator +(int offset) {}
+}
+f() {
+  E('a') + 1;
+}
+''');
+  }
+
+  test_binary_undefined() async {
+    await assertErrorsInCode('''
+extension E on String {}
+f() {
+  E('a') + 1;
+}
+''', [
+      error(CompileTimeErrorCode.UNDEFINED_EXTENSION_OPERATOR, 40, 1),
+    ]);
+    var binaryExpression = findNode.binary('+ 1');
+    assertElementNull(binaryExpression);
+    assertInvokeTypeNull(binaryExpression);
+    assertTypeDynamic(binaryExpression);
+  }
+}