Skip to content

Commit 1c512ef

Browse files
sgrekhovathomas
authored andcommitted
[co19] Enable more migrated "Language" tests
Change-Id: Ib5e450d90bcce0a96d65f088b292b5db2ade1f5e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152342 Reviewed-by: Alexander Thomas <[email protected]>
1 parent 0a77a1f commit 1c512ef

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

tests/co19/co19-co19.status

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,15 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44

5-
Language/Classes/Constructors/Factories/*: Skip # Not migrated to NNBD
6-
Language/Classes/Constructors/Generative_Constructors/*: Skip # Not migrated to NNBD
5+
Language/Classes/Constructors/Factories/redirecting_constructor_call_t03: Skip # Type aliases are not fully implemented
6+
Language/Classes/Constructors/Factories/redirecting_constructor_t04: Skip # Type aliases are not fully implemented
77
Language/Classes/Superclasses/Inheritance_and_Overriding/inheritance_t07: Skip # Type aliases are not fully implemented
8-
Language/Expressions/Assignment/Compound_Assignment/*: Skip # Not migrated to NNBD
98
Language/Expressions/Assignment/Compound_Assignment/null_aware_compound_assignment_static_t12: Skip # Triple shift is not implemented yet
109
Language/Expressions/Assignment/Compound_Assignment/null_aware_compound_assignment_t12: Skip # Triple shift is not implemented yet
1110
Language/Expressions/Assignment/Compound_Assignment/variable_assignment_t12: Skip # Triple shift is not implemented yet
1211
Language/Expressions/Bitwise_Expressions/syntax_t01: Skip # Triple shift is not implemented yet
13-
Language/Expressions/Constants/*: Skip # Not migrated to NNBD
12+
Language/Expressions/Constants/bitwise_operators_t01: Skip # Triple shift is not implemented yet
1413
Language/Expressions/Equality/syntax_t01: Skip # Triple shift is not implemented yet
15-
Language/Expressions/Identifier_Reference/*: Skip # Not migrated to NNBD
1614
Language/Expressions/Instance_Creation/New/type_t09: Skip # Type aliases are not fully implemented
1715
Language/Expressions/Lists/syntax_t01: Skip # Triple shift is not implemented yet
1816
Language/Expressions/Maps/syntax_t01: Skip # Triple shift is not implemented yet
@@ -327,8 +325,6 @@ Language/Classes/Constructors/Constant_Constructors/superinitializer_t05: Skip #
327325
Language/Classes/Constructors/Constant_Constructors/superinitializer_t06: Skip # github.com/dart-lang/language/issues/115
328326
Language/Classes/Constructors/Factories/name_t06: Skip # github.com/dart-lang/language/issues/115
329327
Language/Classes/Constructors/Factories/name_t07: Skip # github.com/dart-lang/language/issues/115
330-
Language/Classes/Constructors/Factories/redirecting_constructor_call_t03: Skip # github.com/dart-lang/language/issues/115
331-
Language/Classes/Constructors/Factories/redirecting_constructor_t04: Skip # github.com/dart-lang/language/issues/115
332328
Language/Classes/Constructors/Factories/redirecting_to_itself_t05: Skip # github.com/dart-lang/language/issues/115
333329
Language/Classes/Constructors/Factories/redirecting_to_itself_t06: Skip # github.com/dart-lang/language/issues/115
334330
Language/Classes/Constructors/Factories/redirecting_to_itself_t07: Skip # github.com/dart-lang/language/issues/115

tests/co19/co19-dart2js.status

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
# BSD-style license that can be found in the LICENSE file.
44

55
[ $compiler == dart2js ]
6+
Language/Expressions/Constants/integer_size_t03: SkipByDesign # big integer cannot be represented in JavaScript
7+
Language/Expressions/Constants/integer_size_t04: SkipByDesign # big integer cannot be represented in JavaScript
8+
Language/Expressions/Constants/literal_number_t01: SkipByDesign # big integer cannot be represented in JavaScript
9+
Language/Expressions/Constants/math_operators_t01: SkipByDesign # big integer cannot be represented in JavaScript
10+
Language/Expressions/Constants/math_operators_t06: SkipByDesign # big integer cannot be represented in JavaScript
611
Language/Expressions/Null/instance_of_class_null_t01: Skip # dart:mirrors not supported https://github.com/dart-lang/co19/issues/522.
712
Language/Expressions/Numbers/integer_size_t03: SkipByDesign # big integer cannot be represented in JavaScript
813
Language/Expressions/Numbers/static_type_of_int_t01: SkipByDesign # big integer cannot be represented in JavaScript

tests/co19/co19-dartdevc.status

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ Language/Classes/Instance_Variables/definition_t01: Skip # Times out
5252
Language/Classes/Instance_Variables/definition_t02: Skip # Times out
5353
Language/Classes/Instance_Variables/definition_t04: Skip # Times out
5454
Language/Classes/Setters/instance_setter_t01: Skip # Times out
55+
Language/Expressions/Constants/integer_size_t03: SkipByDesign # big integer cannot be represented in JavaScript
56+
Language/Expressions/Constants/integer_size_t04: SkipByDesign # big integer cannot be represented in JavaScript
57+
Language/Expressions/Constants/literal_number_t01: SkipByDesign # big integer cannot be represented in JavaScript
58+
Language/Expressions/Constants/math_operators_t01: SkipByDesign # big integer cannot be represented in JavaScript
59+
Language/Expressions/Constants/math_operators_t06: SkipByDesign # big integer cannot be represented in JavaScript
5560
Language/Expressions/Function_Invocation/async_generator_invokation_t08: Skip # Times out
5661
Language/Expressions/Function_Invocation/async_generator_invokation_t10: Skip # Times out
5762
Language/Expressions/Null/instance_of_class_null_t01: Skip # dart:mirrors not supported https://github.com/dart-lang/co19/issues/522.

0 commit comments

Comments
 (0)