fix: fixed trello tick running even when context arent there triggering sentry errors

Author: danniehansen

src/capabilities/card-back-section/view.vue

@@ -253,37 +253,64 @@ const displayedMembers = computed(() => {
 });
 
 const trelloTick = async () => {
-  if (!cardId) {
-    cardId = (await getTrelloCard().card('id')).id;
-  }
+  try {
+    // Check if we have valid board context before proceeding
+    const context = getTrelloCard().getContext();
+    if (!context.board) {
+      console.debug(
+        '[activity-timer] Board context missing, skipping trelloTick'
+      );
+      return;
+    }
 
-  canWrite.value = await getTrelloCard().memberCanWriteToModel('card');
-  visible.value = await isVisible();
-  hasEstimates.value = await hasEstimateFeature();
+    if (!cardId) {
+      cardId = (await getTrelloCard().card('id')).id;
+    }
 
-  const memberId = await getMemberId();
-  const card = getCardModel();
+    canWrite.value = await getTrelloCard().memberCanWriteToModel('card');
+    visible.value = await isVisible();
+    hasEstimates.value = await hasEstimateFeature();
 
-  isTracking.value = await card.isRunning();
-  trackedTime.value = await card.getTimeSpent();
+    const memberId = await getMemberId();
+    const card = getCardModel();
 
-  const estimates = await card.getEstimates();
-  totalEstimate.value = estimates.totalEstimate;
+    isTracking.value = await card.isRunning();
+    trackedTime.value = await card.getTimeSpent();
 
-  const ownEstimateItem = estimates.getByMemberId(memberId);
+    const estimates = await card.getEstimates();
+    totalEstimate.value = estimates.totalEstimate;
 
-  if (ownEstimateItem) {
-    ownEstimate.value = ownEstimateItem.time;
-  } else {
-    ownEstimate.value = 0;
-  }
+    const ownEstimateItem = estimates.getByMemberId(memberId);
 
-  // Load member summary
-  await loadMemberSummary();
+    if (ownEstimateItem) {
+      ownEstimate.value = ownEstimateItem.time;
+    } else {
+      ownEstimate.value = 0;
+    }
 
-  // Resize iframe after data changes
-  await nextTick();
-  setTimeout(resizeTrelloFrame, 100);
+    // Load member summary
+    await loadMemberSummary();
+
+    // Resize iframe after data changes
+    await nextTick();
+    setTimeout(resizeTrelloFrame, 100);
+  } catch (e) {
+    // Silently handle context errors when board is no longer available
+    // This commonly occurs when the card is closed or user navigates away
+    const errorStr = String(e);
+    if (
+      errorStr.includes('Invalid context') ||
+      errorStr.includes('missing board')
+    ) {
+      console.debug(
+        '[activity-timer] Board context lost during trelloTick, ignoring'
+      );
+      return;
+    }
+
+    // Re-throw unexpected errors
+    throw e;
+  }
 };
 
 const loadMemberSummary = async () => {

src/components/trello.ts

@@ -177,48 +177,3 @@ export async function getTokenDetails(): Promise<TrelloToken | undefined> {
 
   return undefined;
 }
-
-/**
- * Shows a native Trello confirmation popup.
- * Returns a promise that resolves to true if confirmed, false if cancelled.
- *
- * @param title - The title of the confirmation dialog
- * @param message - The message/body text
- * @param options - Optional configuration
- * @param options.confirmText - Text for the confirm button (default: "Confirm")
- * @param options.confirmStyle - Style of the confirm button: 'primary' | 'danger' (default: 'primary')
- * @param options.cancelText - Text for the cancel button (default: "Cancel")
- * @param options.mouseEvent - Mouse event for positioning the popup
- */
-export function showConfirm(
-  title: string,
-  message: string,
-  options?: {
-    confirmText?: string;
-    confirmStyle?: 'primary' | 'danger';
-    cancelText?: string;
-    mouseEvent?: MouseEvent;
-  }
-): Promise<boolean> {
-  return new Promise((resolve) => {
-    const t = getTrelloCard();
-
-    t.popup({
-      type: 'confirm',
-      title,
-      message,
-      confirmText: options?.confirmText ?? 'Confirm',
-      confirmStyle: options?.confirmStyle ?? 'primary',
-      cancelText: options?.cancelText ?? 'Cancel',
-      mouseEvent: options?.mouseEvent,
-      onConfirm: () => {
-        resolve(true);
-        return Promise.resolve();
-      },
-      onCancel: () => {
-        resolve(false);
-        return Promise.resolve();
-      }
-    });
-  });
-}