Reviewer comments

Author: web-flow

lib/vf_analyzers.cpp

@@ -1606,7 +1606,7 @@ ValuePtr<Analyzer> makeAnalyzer(const Token* exprTok, ValueFlow::Value value, co
 
 ValuePtr<Analyzer> makeReverseAnalyzer(const Token* exprTok, ValueFlow::Value value, const Settings& settings)
 {
-    value.setFlow(ValueFlow::Value::Flow::REVERSE);
+    value.setDirection(ValueFlow::Value::Direction::Reverse);
     if (value.isContainerSizeValue())
         return ContainerExpressionAnalyzer(exprTok, std::move(value), settings);
     return ExpressionAnalyzer(exprTok, std::move(value), settings);

lib/vfvalue.h

@@ -346,19 +346,19 @@ namespace ValueFlow
         };
         UnknownFunctionReturn unknownFunctionReturn{UnknownFunctionReturn::no};
 
-        enum class Flow : std::uint8_t {
-            UNKNOWN,
-            FORWARD,
-            REVERSE
-        } flow = Flow::UNKNOWN;
+        enum class Direction : std::uint8_t {
+            Unknown,
+            Forward,
+            Reverse
+        } direction = Direction::Unknown;
         bool isReverse() const {
-            return flow == Flow::REVERSE;
+            return direction == Direction::Reverse;
         }
-        void setFlow(Flow f) {
-            flow = f;
+        void setDirection(Direction d) {
+            direction = d;
         }
 
-        long long : 16; // padding
+        unsigned int : 16; // padding
 
         /** Path id */
         MathLib::bigint path{};