make hide() work with {shinycssloaders}; fixes #276

Author: daattali

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: shinyjs
 Title: Easily Improve the User Experience of Your Shiny Apps in Seconds
-Version: 2.1.0.9006
+Version: 2.1.0.9007
 Authors@R: person("Dean", "Attali", 
     email = "[email protected]",
     role = c("aut", "cre"),

NEWS.md

@@ -2,6 +2,7 @@
 
 - **BREAKING CHANGE** The `useShinyjs()` function no longer accepts any parameters. The `rmd` and `html` arguments are not needed (they are now detected automatically). The `debug` argument is now set using R options: `options("shinyjs.debug" = TRUE)`.
 - **DEPRECATION NOTICE** The `runExample()` function is no longer required since {shiny} version 1.8.1 (March 2024). You can now use `shiny::runExample("demo", package = "shinyjs")` instead of `shinyjs::runExample("demo")`.
+- Fix bug: `hide()` now works with spinners from {shinycssloaders} (#276)
 - Fix bug: `hidden()` and `disabled()` now work with tags that have a `htmlDependency()` (#252)
 - Fix bug: `hidden()` and `disabled()` now return a `tagList()` instead of a `list()` when appropriate
 - Fix bug: `disable()` now works with file inputs (#249)

inst/srcjs/shinyjs-default-funcs.js

@@ -43,8 +43,8 @@ shinyjs = function() {
     }
   };
 
-  // if the given HTML tag is a shiny input, return the input container.
-  // otherwise, return the original tag
+  // if the given HTML tag is a shiny input or is wrapped in a {shinycssloaders} spinner,
+  // return the container. Otherwise, return the original tag
   var _getContainer = function(els) {
     return $.map(els, function(el) {
       el = $(el);
@@ -53,6 +53,11 @@ shinyjs = function() {
         if (inputContainer.length > 0) {
           el = inputContainer;
         }
+      } else if (el.hasClass("shiny-bound-output")) {
+        let outputContainer = el.closest(".shiny-spinner-output-container");
+        if (outputContainer.length > 0) {
+          el = outputContainer;
+        }
       }
       return el;
     });