rewrite complex ifs with switch

Author: pashagolub

internal/reaper/database.go

@@ -708,11 +708,12 @@ func FetchMetricsPgpool(ctx context.Context, msg MetricFetchConfig, vme Monitore
 					retRow[k] = vs
 					if k == "status" { // was changed from numeric to string at some pgpool version so leave the string
 						// but also add "status_num" field
-						if vs == "up" {
+						switch vs {
+						case "up":
 							retRow["status_num"] = 1
-						} else if vs == "down" {
+						case "down":
 							retRow["status_num"] = 0
-						} else {
+						default:
 							i, err := strconv.ParseInt(vs, 10, 64)
 							if err == nil {
 								retRow["status_num"] = i

internal/sinks/postgres.go

@@ -295,7 +295,8 @@ func (pgw *PostgresWriter) flush(msgs []metrics.MeasurementEnvelope) {
 
 			rowsBatched++
 
-			if pgw.metricSchema == DbStorageSchemaTimescale {
+			switch pgw.metricSchema {
+			case DbStorageSchemaTimescale:
 				// set min/max timestamps to check/create partitions
 				bounds, ok := pgPartBounds[msg.MetricName]
 				if !ok || (ok && epochTime.Before(bounds.StartTime)) {
@@ -306,7 +307,7 @@ func (pgw *PostgresWriter) flush(msgs []metrics.MeasurementEnvelope) {
 					bounds.EndTime = epochTime
 					pgPartBounds[msg.MetricName] = bounds
 				}
-			} else if pgw.metricSchema == DbStorageSchemaPostgres {
+			case DbStorageSchemaPostgres:
 				_, ok := pgPartBoundsDbName[msg.MetricName]
 				if !ok {
 					pgPartBoundsDbName[msg.MetricName] = make(map[string]ExistingPartitionInfo)
@@ -320,6 +321,8 @@ func (pgw *PostgresWriter) flush(msgs []metrics.MeasurementEnvelope) {
 					bounds.EndTime = epochTime
 					pgPartBoundsDbName[msg.MetricName][msg.DBName] = bounds
 				}
+			default:
+				logger.Fatal("unknown storage schema...")
 			}
 		}
 	}

internal/sinks/prometheus.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"net"
 	"net/http"
-	"reflect"
 	"slices"
 	"strconv"
 	"strings"
@@ -230,21 +229,17 @@ func (promw *PrometheusWriter) MetricStoreMessageToPromMetrics(msg metrics.Measu
 				tag := k[4:]
 				labels[tag] = fmt.Sprintf("%v", v)
 			} else {
-				dataType := reflect.TypeOf(v).String()
-				if dataType == "float64" || dataType == "float32" || dataType == "int64" || dataType == "int32" || dataType == "int" {
+				switch t := v.(type) {
+				case int, int32, int64, float32, float64:
 					f, err := strconv.ParseFloat(fmt.Sprintf("%v", v), 64)
 					if err != nil {
-						logger.Debugf("Skipping scraping column %s of [%s:%s]: %v", k, msg.DBName, msg.MetricName, err)
+						logger.Debugf("skipping scraping column %s of [%s:%s]: %v", k, msg.DBName, msg.MetricName, err)
 					}
 					fields[k] = f
-				} else if dataType == "bool" {
-					if v.(bool) {
-						fields[k] = 1
-					} else {
-						fields[k] = 0
-					}
-				} else {
-					logger.Debugf("Skipping scraping column %s of [%s:%s], unsupported datatype: %s", k, msg.DBName, msg.MetricName, dataType)
+				case bool:
+					fields[k] = map[bool]float64{true: 1, false: 0}[t]
+				default:
+					logger.Debugf("skipping scraping column %s of [%s:%s], unsupported datatype: %v", k, msg.DBName, msg.MetricName, t)
 					continue
 				}
 			}