[-] fix linter warning "impossible condition: nil != nil" (#652)

Author: pashagolub

.golangci.yml

@@ -9,13 +9,13 @@ linters:
 linters-settings:
   gocyclo:
     # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    min-complexity: 50
+    min-complexity: 20
 
 issues:
   # List of regexps of issue texts to exclude, empty list by default.
   # But independently of this option we use default exclude patterns,
   # it can be disabled by `exclude-use-default: false`. To list all
   # excluded by default patterns execute `golangci-lint run --help`
   exclude:
-    - CPUTimesStat # SA1019: CPUTimesStat is deprecated
-    - SA5008       # duplicate struct tag "choice" (staticcheck)
+    - SA1019  # CPUTimesStat.Total is deprecated
+    - SA5008  # duplicate struct tag "choice" (staticcheck)

internal/metrics/psutil/psutil.go

@@ -181,7 +181,7 @@ func GetGoPsutilDiskPG(DataDirs, TblspaceDirs []map[string]any) ([]map[string]an
 		if err != nil {
 			return nil, err
 		}
-		if err != nil || ldDevice != ddDevice { // no point to report same data in case of single folder configuration
+		if ldDevice != ddDevice { // no point to report same data in case of single folder configuration
 			ld := make(map[string]any)
 			ldUsage, err := disk.Usage(logDirPath)
 			if err != nil {
@@ -212,7 +212,7 @@ func GetGoPsutilDiskPG(DataDirs, TblspaceDirs []map[string]any) ([]map[string]an
 			return nil, err
 		}
 
-		if err != nil || walDevice != ddDevice || walDevice != ldDevice { // no point to report same data in case of single folder configuration
+		if walDevice != ddDevice || walDevice != ldDevice { // no point to report same data in case of single folder configuration
 			walUsage, err := disk.Usage(walDirPath)
 			if err != nil {
 				return nil, err