Skip to content

Commit 7fdc776

Browse files
hkallweitkuba-moo
authored andcommitted
Revert "net: phy: meson-gxl: improve link-up behavior"
This reverts commit 2c87c6f. Meanwhile it turned out that the following commit is the proper workaround for the issue that 2c87c6f tries to address. a3a57bf ("net: stmmac: work around sporadic tx issue on link-up") It's nor clear why the to be reverted commit helped for one user, for others it didn't make a difference. Fixes: 2c87c6f ("net: phy: meson-gxl: improve link-up behavior") Signed-off-by: Heiner Kallweit <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 42e66b1 commit 7fdc776

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

drivers/net/phy/meson-gxl.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -243,13 +243,7 @@ static irqreturn_t meson_gxl_handle_interrupt(struct phy_device *phydev)
243243
irq_status == INTSRC_ENERGY_DETECT)
244244
return IRQ_HANDLED;
245245

246-
/* Give PHY some time before MAC starts sending data. This works
247-
* around an issue where network doesn't come up properly.
248-
*/
249-
if (!(irq_status & INTSRC_LINK_DOWN))
250-
phy_queue_state_machine(phydev, msecs_to_jiffies(100));
251-
else
252-
phy_trigger_machine(phydev);
246+
phy_trigger_machine(phydev);
253247

254248
return IRQ_HANDLED;
255249
}

0 commit comments

Comments
 (0)