Remove metrics for cli-tool

Author: syndicut

server/check.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 
 	log "github.com/sirupsen/logrus"
-	v1 "k8s.io/api/admission/v1"
+	admissionv1 "k8s.io/api/admission/v1"
 )
 
 func Check() {
@@ -28,8 +28,6 @@ func Check() {
 		log.Fatal(err)
 	}
 
-	registerMetrics()
-
 	loadedPlugins, err := loadPlugins(pluginsPathGlob, cfg)
 	if err != nil {
 		log.Fatal(err)
@@ -51,7 +49,7 @@ func Check() {
 
 	allowed := true
 
-	results := make(map[string][]v1.AdmissionReview)
+	results := make(map[string][]admissionv1.AdmissionReview)
 
 	if stat.IsDir() {
 		err := filepath.Walk(inputFile, func(path string, info fs.FileInfo, err error) error {

server/server.go

@@ -29,14 +29,14 @@ import (
 	"github.com/cruise-automation/k-rail/v3/policies"
 	"github.com/gertd/go-pluralize"
 	"github.com/gorilla/mux"
+	"github.com/prometheus/client_golang/prometheus"
 	log "github.com/sirupsen/logrus"
 	admissionv1 "k8s.io/api/admission/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/json"
 	"k8s.io/apimachinery/pkg/util/yaml"
 
-	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	"github.com/slok/go-http-metrics/middleware/std"
 )
@@ -75,7 +75,9 @@ func Run(ctx context.Context) {
 		log.Fatal(err)
 	}
 
-	registerMetrics()
+	prometheus.MustRegister(totalRegisteredPolicies)
+	prometheus.MustRegister(policyViolations)
+	prometheus.MustRegister(totalLoadedPlugins)
 
 	loadedPlugins, err := loadPlugins(pluginsPathGlob, cfg)
 	if err != nil {
@@ -143,12 +145,6 @@ func Run(ctx context.Context) {
 	log.Fatal(s.ListenAndServeTLS(cfg.TLS.Cert, cfg.TLS.Key))
 }
 
-func registerMetrics() {
-	prometheus.MustRegister(totalRegisteredPolicies)
-	prometheus.MustRegister(policyViolations)
-	prometheus.MustRegister(totalLoadedPlugins)
-}
-
 func parseFlags() (string, string, string) {
 	configPath := flag.String("config", "config.yml", "path to configuration file")
 	exemptionsPathGlob := flag.String("exemptions-path-glob", "", "path glob that includes exemption configs")