Skip to content

Commit 7e8d0d7

Browse files
committed
fix: ignore diff for trailing dots in Record.route53 names
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
1 parent 3d80d7d commit 7e8d0d7

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

config/cluster/route53/config.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
package route53
66

77
import (
8+
"strings"
9+
810
"github.com/crossplane/upjet/v2/pkg/config"
11+
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
912
)
1013

1114
// Configure adds configurations for the route53 group.
@@ -32,6 +35,19 @@ func Configure(p *config.Provider) { //nolint:gocyclo
3235
}
3336
delete(r.References, "alias.name")
3437
delete(r.References, "alias.zone_id")
38+
r.TerraformCustomDiff = func(diff *terraform.InstanceDiff, state *terraform.InstanceState, config *terraform.ResourceConfig) (*terraform.InstanceDiff, error) {
39+
if diff == nil || diff.Empty() || diff.Destroy || diff.Attributes == nil {
40+
return diff, nil
41+
}
42+
nameDiff, ok := diff.Attributes["name"]
43+
if !ok {
44+
return diff, nil
45+
}
46+
if strings.TrimSuffix(nameDiff.New, ".") == strings.TrimSuffix(nameDiff.Old, ".") {
47+
delete(diff.Attributes, "name")
48+
}
49+
return diff, nil
50+
}
3551
})
3652
p.AddResourceConfigurator("aws_route53_vpc_association_authorization", func(r *config.Resource) {
3753
r.References["zone_id"] = config.Reference{

0 commit comments

Comments
 (0)