chore: fix local build - #79
Closed
rslangl wants to merge 5 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build infrastructure to fix local build issues by replacing the Upbound build submodule with Crossplane's build submodule and updating various tool versions to maintain compatibility.
Key Changes:
- Migrated build submodule from Upbound to Crossplane repository
- Updated tool versions (Kind, Go, golangci-lint, Helm, Up) to newer releases
- Modernized golangci-lint configuration for version 2.2.0 compatibility
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build | Updates submodule commit to point to Crossplane build repository |
| Makefile | Updates tool versions (Kind, Go, golangci-lint, Helm, Up) and fixes XPKGS variable |
| .golangci.yml | Adds version 2 specification and replaces deprecated linters with modern equivalents |
| .gitmodules | Changes build submodule URL from Upbound to Crossplane |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: rslangl <fjellape1447@protonmail.com> Signed-off-by: rslangl <>
Signed-off-by: rslangl <fjellape1447@protonmail.com> Signed-off-by: rslangl <>
Signed-off-by: rslangl <fjellape1447@protonmail.com> Signed-off-by: rslangl <>
Signed-off-by: rslangl <fjellape1447@protonmail.com> Signed-off-by: rslangl <>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: rslangl <>
Collaborator
|
Closed by #86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Replaces the old upbound build submodule with the one provided by crossplane and updated package versions to ensure successful local build.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewable testfails due to golangci-lint. However, this PR does not touch actual code. Thus, I left this checkbox uncheckedearthly +reviewablefails, pointing to a missinggenerate.gofile