feat: support scopes & no more delete on update

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>

Author: BoxBoxJason

apis/cluster/instance/v1alpha1/zz_application_types.go

@@ -29,44 +29,50 @@ import (
 type ApplicationParameters struct {
 	// Name is the name of the application.
 	// +required
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Name is immutable (delete and recreate the resource if you want to change it)."
 	Name string `json:"name"`
 
 	// RedirectURI is the redirect URI of the application.
 	// +required
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="RedirectURI is immutable (delete and recreate the resource if you want to change it)."
 	RedirectURI string `json:"redirectURI"`
 
 	// Scopes is the scopes of the application (space-separated).
-	// WARNING: This field is not updated after creation. To change scopes, you must delete and recreate the application.
 	// +required
-	// +immutable
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Scopes is immutable (delete and recreate the resource if you want to change it)."
 	Scopes []string `json:"scopes"`
 
 	// Confidential indicates whether the application is confidential.
 	// +optional
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Confidential is immutable (delete and recreate the resource if you want to change it)."
 	Confidential *bool `json:"confidential,omitempty"`
 }
 
 // ApplicationObservation represents the observed state of a GitLab instance OAuth Application.
 type ApplicationObservation struct {
 	// ID is the numeric ID of the application.
 	// +optional
-	ID int64 `json:"id,omitempty"`
+	ID int64 `json:"id"`
 
 	// Name is the name of the application as stored in GitLab.
 	// +optional
-	Name string `json:"name,omitempty"`
+	Name string `json:"name"`
 
 	// ApplicationID is the OAuth client ID.
 	// +optional
-	ApplicationID string `json:"applicationID,omitempty"`
+	ApplicationID string `json:"applicationID"`
 
 	// CallbackURL is the callback URL of the application as stored in GitLab.
 	// +optional
-	CallbackURL string `json:"callbackURL,omitempty"`
+	CallbackURL string `json:"callbackURL"`
 
 	// Confidential indicates whether the application is confidential.
 	// +optional
-	Confidential bool `json:"confidential,omitempty"`
+	Confidential bool `json:"confidential"`
+
+	// Scopes is the scopes of the application as stored in GitLab
+	// +optional
+	Scopes []string `json:"scopes"`
 }
 
 // ApplicationSpec defines the desired state of a GitLab instance OAuth Application.

apis/cluster/instance/v1alpha1/zz_generated.deepcopy.go

@@ -8,7 +8,7 @@ require (
 	github.com/google/go-cmp v0.7.0
 	github.com/hashicorp/go-cleanhttp v0.5.2
 	github.com/pkg/errors v0.9.1
-	gitlab.com/gitlab-org/api/client-go/v2 v2.34.0
+	gitlab.com/gitlab-org/api/client-go/v2 v2.39.0
 	go.uber.org/zap v1.27.1
 	golang.org/x/oauth2 v0.36.0
 	k8s.io/api v0.35.1

apis/namespaced/instance/v1alpha1/application_types.go

@@ -105,8 +105,8 @@ github.com/google/pprof v0.0.0-20251213031049-b05bdaca462f h1:HU1RgM6NALf/KW9HEY
 github.com/google/pprof v0.0.0-20251213031049-b05bdaca462f/go.mod h1:67FPmZWbr+KDT/VlpWtw6sO9XSjpJmLuHpoLmWiTGgY=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
 github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
-github.com/graph-gophers/graphql-go v1.9.0 h1:yu0ucKHLc5qGpRwLYKIWtr9bOoxovkWasuBrPQwlHls=
-github.com/graph-gophers/graphql-go v1.9.0/go.mod h1:23olKZ7duEvHlF/2ELEoSZaY1aNPfShjP782SOoNTyM=
+github.com/graph-gophers/graphql-go v1.10.2 h1:HXu6Wu5klCH4ALn1fQHVI20cjEIa4wftavHIgbLA4Fo=
+github.com/graph-gophers/graphql-go v1.10.2/go.mod h1:AsADheC4CCFwd8n1/QbkduTlHgYYMsRgtPihYVAlEsk=
 github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.7 h1:X+2YciYSxvMQK0UZ7sg45ZVabVZBeBuvMkmuI2V3Fak=
 github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.7/go.mod h1:lW34nIZuQ8UDPdkon5fmfp2l3+ZkQ2me/+oecHYLOII=
 github.com/hashicorp/go-cleanhttp v0.5.2 h1:035FKYIWjmULyFRBKPs8TBQoi0x6d9G4xc9neXJWAZQ=
@@ -187,8 +187,8 @@ github.com/x448/float16 v0.8.4 h1:qLwI1I70+NjRFUR3zs1JPUCgaCXSh3SW62uAKT1mSBM=
 github.com/x448/float16 v0.8.4/go.mod h1:14CWIYCyZA/cWjXOioeEpHeN/83MdbZDRQHoFcYsOfg=
 github.com/xhit/go-str2duration/v2 v2.1.0 h1:lxklc02Drh6ynqX+DdPyp5pCKLUQpRT8bp8Ydu2Bstc=
 github.com/xhit/go-str2duration/v2 v2.1.0/go.mod h1:ohY8p+0f07DiV6Em5LKB0s2YpLtXVyJfNt1+BlmyAsU=
-gitlab.com/gitlab-org/api/client-go/v2 v2.34.0 h1:3Gv+41azLlj97fUkhkaTCnIOm45mHDwLlAcTDEwHE2s=
-gitlab.com/gitlab-org/api/client-go/v2 v2.34.0/go.mod h1:T+hA9p13Fxyh4FkVbcEy36HlAGs37QBCifhh7Zt4+dg=
+gitlab.com/gitlab-org/api/client-go/v2 v2.39.0 h1:avIIRj2sia1bGYCXy6nIeuBFWNzwQppZf+eGjVMNh7E=
+gitlab.com/gitlab-org/api/client-go/v2 v2.39.0/go.mod h1:SKUbKSS59KPt6WeGNJoYF8HDaf/rFMUSITlftj/HkLg=
 go.opentelemetry.io/auto/sdk v1.2.1 h1:jXsnJ4Lmnqd11kwkBV2LgLoFMZKizbCi5fNZ/ipaZ64=
 go.opentelemetry.io/auto/sdk v1.2.1/go.mod h1:KRTj+aOaElaLi+wW1kO/DZRXwkF4C5xPbEe3ZiIhN7Y=
 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.64.0 h1:ssfIgGNANqpVFCndZvcuyKbl0g+UAVcbBcqGkG28H0Y=

apis/namespaced/instance/v1alpha1/zz_generated.deepcopy.go

@@ -89,19 +89,33 @@ spec:
                     description: Confidential indicates whether the application is
                       confidential.
                     type: boolean
+                    x-kubernetes-validations:
+                    - message: Confidential is immutable (delete and recreate the
+                        resource if you want to change it).
+                      rule: self == oldSelf
                   name:
                     description: Name is the name of the application.
                     type: string
+                    x-kubernetes-validations:
+                    - message: Name is immutable (delete and recreate the resource
+                        if you want to change it).
+                      rule: self == oldSelf
                   redirectURI:
                     description: RedirectURI is the redirect URI of the application.
                     type: string
+                    x-kubernetes-validations:
+                    - message: RedirectURI is immutable (delete and recreate the resource
+                        if you want to change it).
+                      rule: self == oldSelf
                   scopes:
-                    description: |-
-                      Scopes is the scopes of the application (space-separated).
-                      WARNING: This field is not updated after creation. To change scopes, you must delete and recreate the application.
+                    description: Scopes is the scopes of the application (space-separated).
                     items:
                       type: string
                     type: array
+                    x-kubernetes-validations:
+                    - message: Scopes is immutable (delete and recreate the resource
+                        if you want to change it).
+                      rule: self == oldSelf
                 required:
                 - name
                 - redirectURI
@@ -220,6 +234,12 @@ spec:
                     description: Name is the name of the application as stored in
                       GitLab.
                     type: string
+                  scopes:
+                    description: Scopes is the scopes of the application as stored
+                      in GitLab
+                    items:
+                      type: string
+                    type: array
                 type: object
               conditions:
                 description: Conditions of the resource.

go.mod

@@ -75,19 +75,33 @@ spec:
                     description: Confidential indicates whether the application is
                       confidential.
                     type: boolean
+                    x-kubernetes-validations:
+                    - message: Confidential is immutable (delete and recreate the
+                        resource if you want to change it).
+                      rule: self == oldSelf
                   name:
                     description: Name is the name of the application.
                     type: string
+                    x-kubernetes-validations:
+                    - message: Name is immutable (delete and recreate the resource
+                        if you want to change it).
+                      rule: self == oldSelf
                   redirectURI:
                     description: RedirectURI is the redirect URI of the application.
                     type: string
+                    x-kubernetes-validations:
+                    - message: RedirectURI is immutable (delete and recreate the resource
+                        if you want to change it).
+                      rule: self == oldSelf
                   scopes:
-                    description: |-
-                      Scopes is the scopes of the application (space-separated).
-                      WARNING: This field is not updated after creation. To change scopes, you must delete and recreate the application.
+                    description: Scopes is the scopes of the application (space-separated).
                     items:
                       type: string
                     type: array
+                    x-kubernetes-validations:
+                    - message: Scopes is immutable (delete and recreate the resource
+                        if you want to change it).
+                      rule: self == oldSelf
                 required:
                 - name
                 - redirectURI
@@ -178,6 +192,12 @@ spec:
                     description: Name is the name of the application as stored in
                       GitLab.
                     type: string
+                  scopes:
+                    description: Scopes is the scopes of the application as stored
+                      in GitLab
+                    items:
+                      type: string
+                    type: array
                 type: object
               conditions:
                 description: Conditions of the resource.