fix(applications): wire newArgocdClientFn in Application controller connector

Setup() built the connector without setting newArgocdClientFn (unlike every
other controller, e.g. projects), leaving it nil. Connect() -> NewExternal()
then invokes that nil function pointer, which panics. controller-runtime
recovers the panic and requeues with backoff instead of crashing, so the
Application managed resource silently never reconciles: no error is logged,
no event is recorded, and .status is never populated, even though the
underlying ArgoCD Application is healthy.

Author: gravufo

pkg/controller/cluster/applications/controller.go

@@ -55,7 +55,8 @@ const (
 // Setup adds a controller that reconciles applications.
 func Setup(mgr ctrl.Manager, o xpcontroller.Options) error {
 	return SetupWithExternalConnector(mgr, o, &connector{
-		kube: mgr.GetClient(),
+		kube:              mgr.GetClient(),
+		newArgocdClientFn: applications.NewApplicationServiceClient,
 	})
 }