Merge pull request #33 from crazy-max/update-golangci-lint

update golangci-lint to v2.1.6

Author: crazy-max

.golangci.yml

@@ -1,19 +1,12 @@
-run:
-  timeout: 10m
-  # default uses Go version from the go.mod file, fallback on the env var
-  # `GOVERSION`, fallback on 1.17: https://golangci-lint.run/usage/configuration/#run-configuration
-  go: "1.23"
+version: "2"
 
 linters:
   enable:
     - bodyclose
     - depguard
     - forbidigo
     - gocritic
-    - gofmt
-    - goimports
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - makezero
@@ -23,60 +16,74 @@ linters:
     - revive
     - staticcheck
     - testifylint
-    - typecheck
     - unused
     - whitespace
-  disable-all: true
-
-linters-settings:
-  gocritic:
-    disabled-checks:
-      - "ifElseChain"
-      - "assignOp"
-      - "appendAssign"
-      - "singleCaseSwitch"
-  govet:
-    enable:
-      - nilness
-      - unusedwrite
-  depguard:
+  settings:
+    gocritic:
+      disabled-checks:
+        - "ifElseChain"
+        - "assignOp"
+        - "appendAssign"
+        - "singleCaseSwitch"
+    govet:
+      enable:
+        - nilness
+        - unusedwrite
+    depguard:
+      rules:
+        main:
+          deny:
+            - pkg: "io/ioutil"
+              desc: The io/ioutil package has been deprecated.
+    gosec:
+      config:
+        G306: "0644"
+    testifylint:
+      disable:
+        - "empty"
+        - "bool-compare"
+        - "len"
+        - "negative-positive"
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
     rules:
-      main:
-        deny:
-          - pkg: "io/ioutil"
-            desc: The io/ioutil package has been deprecated.
-  gosec:
-    config:
-      G306: "0644"
-  testifylint:
-    disable:
-      # disable rules that reduce the test condition
-      - "empty"
-      - "bool-compare"
-      - "len"
-      - "negative-positive"
+      -
+        linters:
+          - revive
+        text: stutters
+      -
+        linters:
+          - revive
+        text: empty-block
+      -
+        linters:
+          - revive
+        text: superfluous-else
+      -
+        linters:
+          - revive
+        text: unused-parameter
+      -
+        linters:
+          - revive
+        text: redefines-builtin-id
+      -
+        linters:
+          - revive
+        text: if-return
 
-issues:
-  exclude-rules:
-    - linters:
-        - revive
-      text: "stutters"
-    - linters:
-        - revive
-      text: "empty-block"
-    - linters:
-        - revive
-      text: "superfluous-else"
-    - linters:
-        - revive
-      text: "unused-parameter"
-    - linters:
-        - revive
-      text: "redefines-builtin-id"
-    - linters:
-        - revive
-      text: "if-return"
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
 
-  # show all
+issues:
   max-issues-per-linter: 0
   max-same-issues: 0

Dockerfile

@@ -1,7 +1,7 @@
 # syntax=docker/dockerfile:1
 
 ARG GO_VERSION="1.23"
-ARG GOLANGCI_LINT_VERSION="v1.62"
+ARG GOLANGCI_LINT_VERSION="v2.1.6"
 
 FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint
 

codecov.yml

@@ -3,6 +3,7 @@ comment: false
 coverage:
   status:
     patch: false
+    project: false
 
 github_checks:
   annotations: false

go.mod

@@ -1,3 +1,3 @@
 module github.com/crazy-max/gohealthchecks
 
-go 1.13
+go 1.21.0

healthchecks.go

@@ -54,7 +54,7 @@ func NewClient(o *ClientOptions) *Client {
 
 	c.Timeout = 10 * time.Second
 	c.Transport = roundTripperFunc(func(r *http.Request) (resp *http.Response, err error) {
-		r.Header.Set("User-Agent", fmt.Sprintf("gohealthchecks/%s go/%s %s", version, runtime.Version()[2:], strings.Title(runtime.GOOS)))
+		r.Header.Set("User-Agent", fmt.Sprintf("gohealthchecks/%s go/%s %s", version, runtime.Version()[2:], strings.Title(runtime.GOOS))) //nolint:staticcheck // ignoring "SA1019: strings.Title is deprecated", as for our use we don't need full unicode support
 		u, err := baseURL.Parse(r.URL.String())
 		if err != nil {
 			return nil, err

healthchecks_test.go

@@ -18,7 +18,7 @@ func TestClient(t *testing.T) {
 	defer teardown()
 
 	mux.HandleFunc(fmt.Sprintf("/%s", uuid), func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Success(context.Background(), gohealthchecks.PingingOptions{

pinging_test.go

@@ -18,7 +18,7 @@ func TestSuccess(t *testing.T) {
 	defer teardown()
 
 	mux.HandleFunc(fmt.Sprintf("/%s", uuid), func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Success(context.Background(), gohealthchecks.PingingOptions{
@@ -39,7 +39,7 @@ func TestSuccessLogs(t *testing.T) {
 			t.Fatal(err)
 		}
 		assertEqual(t, "body", string(b), logs)
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Success(context.Background(), gohealthchecks.PingingOptions{
@@ -55,7 +55,7 @@ func TestFail(t *testing.T) {
 	defer teardown()
 
 	mux.HandleFunc(fmt.Sprintf("/%s/fail", uuid), func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Fail(context.Background(), gohealthchecks.PingingOptions{
@@ -76,7 +76,7 @@ func TestFailLogs(t *testing.T) {
 			t.Fatal(err)
 		}
 		assertEqual(t, "body", string(b), logs)
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Fail(context.Background(), gohealthchecks.PingingOptions{
@@ -92,7 +92,7 @@ func TestStart(t *testing.T) {
 	defer teardown()
 
 	mux.HandleFunc(fmt.Sprintf("/%s/start", uuid), func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Start(context.Background(), gohealthchecks.PingingOptions{
@@ -113,7 +113,7 @@ func TestStartLogs(t *testing.T) {
 			t.Fatal(err)
 		}
 		assertEqual(t, "body", string(b), logs)
-		w.Write([]byte(`OK`))
+		_, _ = w.Write([]byte(`OK`))
 	})
 
 	if err := client.Start(context.Background(), gohealthchecks.PingingOptions{