-
Notifications
You must be signed in to change notification settings - Fork 782
[ub] a few more fixes #7888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ub] a few more fixes #7888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the comments I left.
I may do a run over the wording again.
@timuraudio , ping. |
I now applied all the changes suggested here! Are we good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes, hopefully Jens is happy too.
This PR breaks up some
\ubdef
entries in the UB annex into multiple, more granular entries, for those cases of UB where there is value in distinguishing them. This PR makes the list of UB in theub-ifndr
branch identical to the list of UB provided in Appendix A of P3100R2.