Skip to content

[ub] a few more fixes #7888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2025
Merged

[ub] a few more fixes #7888

merged 4 commits into from
Jun 21, 2025

Conversation

timuraudio
Copy link

This PR breaks up some \ubdef entries in the UB annex into multiple, more granular entries, for those cases of UB where there is value in distinguishing them. This PR makes the list of UB in the ub-ifndr branch identical to the list of UB provided in Appendix A of P3100R2.

@hsutter hsutter added the ub-ifndr UB and IFNDR Annex label May 24, 2025
Copy link

@shafik shafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the comments I left.

I may do a run over the wording again.

@jensmaurer
Copy link
Member

@timuraudio , ping.

@timuraudio
Copy link
Author

I now applied all the changes suggested here! Are we good now?

Copy link

@shafik shafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes, hopefully Jens is happy too.

@jensmaurer jensmaurer merged commit 496f1bb into cplusplus:ub-ifndr Jun 21, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ub-ifndr UB and IFNDR Annex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants