Skip to content

Commit a605e4d

Browse files
committed
Fixup: review comments
1 parent 1a93d4a commit a605e4d

File tree

5 files changed

+17
-13
lines changed

5 files changed

+17
-13
lines changed

source/atomics.tex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@
642642
That is,
643643
atomic operations on the same memory location via two different addresses will
644644
communicate atomically.}.
645-
The implementation should not depend on any per-process state.
645+
The implementation of these operations should not depend on any per-process state.
646646
\begin{note}
647647
This restriction enables communication by memory that is
648648
mapped into a process more than once and by memory that is shared between two

source/future.tex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@
570570
\begin{itemize}
571571
\item
572572
\tcode{allocated}, set when a dynamic array object has been
573-
allocated, and hence to be freed by the destructor for the
573+
allocated, and hence will be freed by the destructor for the
574574
\tcode{strstreambuf} object;
575575
\item
576576
\tcode{constant}, set when the array object has

source/iostreams.tex

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -431,11 +431,6 @@
431431
time prior to or during the first time an object of class
432432
\tcode{ios_base::Init} is constructed, and in any case before the body
433433
of \tcode{main}\iref{basic.start.main} begins execution.
434-
435-
\recommended
436-
If it is possible for them to do so, implementations should
437-
initialize the objects earlier than required.
438-
439434
The objects are not destroyed during program execution.\footnote{Constructors and destructors for objects with
440435
static storage duration can
441436
access these objects to read input from
@@ -445,6 +440,13 @@
445440
or
446441
\tcode{stderr}.
447442
}
443+
444+
\pnum
445+
\recommended
446+
If it is possible for them to do so, implementations should
447+
initialize the objects earlier than required.
448+
449+
\pnum
448450
The results of including \libheader{iostream} in a translation unit shall be as if
449451
\libheader{iostream} defined an instance of \tcode{ios_base::Init} with static
450452
storage duration.
@@ -9625,7 +9627,7 @@
96259627
\remarks
96269628
An
96279629
implementation may provide an overriding definition for this function
9628-
signature if it can determine that more characters can be read from the input
9630+
signature if it can determine whether more characters can be read from the input
96299631
sequence.
96309632
\end{itemdescr}
96319633

@@ -11151,8 +11153,8 @@
1115111153
\pnum
1115211154
\begin{note}
1115311155
The member functions of the provided stream buffer
11154-
can called from \tcode{emit()} while a lock is held,
11155-
which might result in a deadlock.
11156+
can be called from \tcode{emit()} while a lock is held,
11157+
which might result in a deadlock if used incautiously.
1115611158
\end{note}
1115711159

1115811160
\pnum

source/threads.tex

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6446,6 +6446,7 @@
64466446
\begin{note}
64476447
It is valid to move from a future object for which \tcode{valid() == false}.
64486448
\end{note}
6449+
64496450
\recommended
64506451
Implementations should detect this case and throw an object of type
64516452
\tcode{future_error} with an error condition of \tcode{future_errc::no_state}.
@@ -6745,6 +6746,7 @@
67456746
It is valid to copy or move from a \tcode{shared_future}
67466747
object for which \tcode{valid()} is \tcode{false}.
67476748
\end{note}
6749+
67486750
\recommended
67496751
Implementations should detect this case and throw an object of type
67506752
\tcode{future_error} with an error condition of \tcode{future_errc::no_state}.

source/utilities.tex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4580,7 +4580,7 @@
45804580
\tcode{t} are as defined by the exception safety guarantee of the assignment
45814581
expression; \tcode{valueless_by_exception()} will be \tcode{false}.
45824582
\item If an exception is thrown during the initialization of the contained value,
4583-
the \tcode{variant} object is permitted not to hold a value.
4583+
the \tcode{variant} object is permitted to not hold a value.
45844584
\end{itemize}
45854585
\end{itemdescr}
45864586

@@ -4664,7 +4664,7 @@
46644664
\pnum
46654665
\remarks
46664666
If an exception is thrown during the initialization of the contained value,
4667-
the \tcode{variant} is permitted not to hold a value.
4667+
the \tcode{variant} is permitted to not hold a value.
46684668
\end{itemdescr}
46694669

46704670
\indexlibrarymember{emplace}{variant}%
@@ -4705,7 +4705,7 @@
47054705
\pnum
47064706
\remarks
47074707
If an exception is thrown during the initialization of the contained value,
4708-
the \tcode{variant} is permitted not to hold a value.
4708+
the \tcode{variant} is permitted to not hold a value.
47094709
\end{itemdescr}
47104710

47114711
\rSec3[variant.status]{Value status}

0 commit comments

Comments
 (0)