fix(ui): respect explicit hide-deleted toggle when soft-deleting rows#774
Merged
fix(ui): respect explicit hide-deleted toggle when soft-deleting rows#774
Conversation
toggleDeleteSelected() unconditionally set ShowDeleted=true after every soft-delete, overriding the user's explicit "hide deleted" preference. Track whether the user has explicitly toggled via 'x' and skip the auto-enable when they have. closes #768 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toggleDeleteSelected()unconditionally setShowDeleted=trueafter every soft-delete, overriding the user's explicit "hide deleted" preferenceshowDeletedExplicitfield toTabto track when the user has explicitly toggled viax; skip auto-enable on delete when setTestDeleteRespectsExplicitHideDeletedcovering the exact reproduction steps: toggle hide-deleted, delete a row, verify the row is hiddencloses #768