Networking metrics (#278)

* operator endpoint in istio

* progress

* WORKING

* fix namespace

* cleanup

* Replace argo with operator DAG manager

* Rename pod check intervals

* Update operator_local

* Skip external dataset check if no environment

* Cap desired replicas at max replicas

* Update api workload succeeded check

* Use Update() instead of Patch() in k8s

* Remove killdev make command

* fix api

* minor fixes

* progress

* https progress

* https

* generate random password

* remove istio READMEs and examples

* clean up

* format

* update lint

* remove vendoring of istio, download at build time

* add back space

* add back eks commands

* remove helm uninstall lines

* clean up

* clean up

* clean up

* address comments

* unexport update

* unexport update

* remove ls, add back uninstall

* progress

* address comments

* remove newlines

* fix api port

* address comments

* clean up install/uninstall

* add license

* add missing istio images

* add to cortex

* wait for istio propagation

* progress

* progress

* progress

* progress

* remove

* track requests

* track response time

* report errors

* lint

* remove error

* undo leftover changes

* remove dev/cortex.sh

* remove json indirect dep

* track requests

* fix ordering

* clean up metrics

* remove api ID

* remove workloadType

* record response time from ingress

* remove istio.yaml

* clean up

* address comments and fix secrets bug

* address comments

* nulls -> null

Author: 1vn

manager/install_cortex.sh

@@ -95,9 +95,19 @@ function setup_istio() {
     echo -n "."
     sleep 5
   done
-
   echo -n "."
-  envsubst < manifests/istio.yaml | helm template istio-manifests/istio --values - --name istio --namespace istio-system | kubectl apply -f - >/dev/null
+  helm template istio-manifests/istio-cni --name istio-cni --namespace kube-system | kubectl apply -f - >/dev/null
+  envsubst < manifests/istio-values.yaml | helm template istio-manifests/istio --values - --name istio --namespace istio-system | kubectl apply -f - >/dev/null
+  envsubst < manifests/istio-metrics.yaml | kubectl apply -f - >/dev/null
+  kubectl -n=istio-system create secret generic 'aws-credentials' \
+    --from-literal='AWS_ACCESS_KEY_ID'=$AWS_ACCESS_KEY_ID \
+    --from-literal='AWS_SECRET_ACCESS_KEY'=$AWS_SECRET_ACCESS_KEY \
+    -o yaml --dry-run | kubectl apply -f - >/dev/null
+  istio_patch="[
+    {\"op\": \"add\", \"path\": \"/spec/template/spec/containers/0/env/-\", \"value\": {\"name\": \"AWS_ACCESS_KEY_ID\", \"valueFrom\": {\"secretKeyRef\": {\"name\": \"aws-credentials\", \"key\": \"AWS_ACCESS_KEY_ID\"}}}},\
+    {\"op\": \"add\", \"path\": \"/spec/template/spec/containers/0/env/-\", \"value\": {\"name\": \"AWS_SECRET_ACCESS_KEY\", \"valueFrom\": {\"secretKeyRef\": {\"name\": \"aws-credentials\", \"key\": \"AWS_SECRET_ACCESS_KEY\"}}}},\
+  ]"
+  kubectl patch deployment istio-telemetry -n istio-system --type='json' -p="$istio_patch"
 }
 
 function validate_cortex() {

manager/manifests/istio-metrics.yaml

@@ -0,0 +1,54 @@
+# Copyright 2019 Cortex Labs, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+apiVersion: config.istio.io/v1alpha2
+kind: instance
+metadata:
+  name: response-time
+  namespace: $CORTEX_NAMESPACE
+spec:
+  compiledTemplate: metric
+  params:
+    value: response.duration
+    dimensions:
+      REQUEST_PATH: request.url_path | "unknown"
+---
+apiVersion: config.istio.io/v1alpha2
+kind: handler
+metadata:
+  name: cortex-request-handler
+  namespace: $CORTEX_NAMESPACE
+spec:
+  compiledAdapter: cloudwatch
+  params:
+    namespace: $CORTEX_NAMESPACE
+    logGroupName: $CORTEX_LOG_GROUP
+    logStreamName: $CORTEX_LOG_GROUP
+    metricInfo:
+      response-time.instance.cortex:
+        unit: Milliseconds
+    logs: {}
+---
+apiVersion: config.istio.io/v1alpha2
+kind: rule
+metadata:
+  name: cortex-api-requests
+  namespace: $CORTEX_NAMESPACE
+spec:
+  match: source.workload.name == "apis-ingressgateway"
+  actions:
+  - handler: cortex-request-handler
+    instances:
+    - response-time
+---

manager/manifests/istio.yaml renamed to manager/manifests/istio-values.yaml

@@ -96,6 +96,9 @@ mixer:
 
   telemetry:
     enabled: true
+  env:
+    AWS_REGION: $CORTEX_REGION
+    LOG_GROUP_NAME: $CORTEX_LOG_GROUP
 
 pilot:
   image: $CORTEX_IMAGE_ISTIO_PILOT