Skip to content

Godeps: update prometheus dependency#3681

Merged
yichengq merged 1 commit into
etcd-io:masterfrom
yichengq:godep-update
Oct 14, 2015
Merged

Godeps: update prometheus dependency#3681
yichengq merged 1 commit into
etcd-io:masterfrom
yichengq:godep-update

Conversation

@yichengq

Copy link
Copy Markdown
Contributor

prometheus updates its directory layout
(https://github.com/prometheus/client_golang#where-is-model-extraction-and-text)
and makes Godeps restore/save unable to work.

Remove all prometheus dependency manually and godep save again to fix
this problem.

/cc @timothysc

prometheus updates its directory layout
(https://github.com/prometheus/client_golang#where-is-model-extraction-and-text)
and makes Godeps restore/save unable to work.

Remove all prometheus dependency manually and godep save again to fix
this problem.
@timothysc

Copy link
Copy Markdown

I think the only way to verify would be to repeat the same commands:

go get github.com/coreos/etcd/etcdserver
godep save -r ./...

@yichengq

Copy link
Copy Markdown
Contributor Author

@timothysc I have tested it and it could work. Moreover, we would recommend people to godep on our stable release, so i am backporting it to branch release-2.2.

@yichengq

Copy link
Copy Markdown
Contributor Author

Merge it as-is due to low risk...

yichengq added a commit that referenced this pull request Oct 14, 2015
Godeps: update prometheus dependency
@yichengq
yichengq merged commit f78ccbb into etcd-io:master Oct 14, 2015
@yichengq
yichengq deleted the godep-update branch October 14, 2015 18:44
@timothysc

Copy link
Copy Markdown

updating my deps and it appears your 'godep -r ./...' on your local repository causes issues on anyone attempting to use, b/c it can't resolve.

Godeps/_workspace/src/github.com/coreos/etcd/storage/backend/backend.go:25:2: cannot find package "github.com/coreos/etcd/Godeps/_workspace/src/github.com/boltdb/bolt" in any of:
/usr/lib/golang/src/github.com/coreos/etcd/Godeps/_workspace/src/github.com/boltdb/bolt (from $GOROOT)
/home/tstclair/work/spaces/kubernetes/src/k8s.io/kubernetes/_output/local/go/src/github.com/coreos/etcd/Godeps/_workspace/src/github.com/boltdb/bolt (from $GOPATH)
/home/tstclair/work/spaces/kubernetes/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/etcd/Godeps/_workspace/src/github.com/boltdb/bolt

I literally get 100s of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants